You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2025/08/13 21:28:58 UTC
[PR] Broker: fail fast when broker marked down; keep IdealState/ExternalView checks out of critical path [pinot]
xiangfu0 opened a new pull request, #16590:
URL: https://github.com/apache/pinot/pull/16590
Context
- Brokers used to wait on IdealState/ExternalView convergence before reporting GOOD.
- When a broker is marked down in ZooKeeper/Helix, we want service status to reflect lifecycle immediately without blocking on heavy IS/EV scans.
Change
- In BaseBrokerStarter.registerServiceStatusHandler, register LifecycleServiceStatusCallback before Helix-based matchers so lifecycle transitions (STARTING/SHUTTING_DOWN) are reported promptly.
- Leave IdealState/CurrentState and IdealState/ExternalView matchers intact for readiness, but they no longer delay lifecycle-driven fail-fast.
Impact
- Faster and more accurate status when a broker is disabled or marked down.
- No additional work on IdealState/ExternalView during shutdown/startup.
Testing
- Compiled pinot-broker with dependencies.
- Manually verified callback order in status description during startup/shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Broker: fail fast when broker marked down; keep IdealState/ExternalView checks out of critical path [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16590:
URL: https://github.com/apache/pinot/pull/16590#issuecomment-3186020934
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16590?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.37%. Comparing base ([`b837df1`](https://app.codecov.io/gh/apache/pinot/commit/b837df10291f99ba3ddf7c09a490ab83400e93d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e84927c`](https://app.codecov.io/gh/apache/pinot/commit/e84927ccf0ce4b16adcfef88a6c22f7a6db6f0be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (b837df1) and HEAD (e84927c). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (b837df1) | HEAD (e84927c) |
>|------|------|------|
>|unittests2|2|0|
>|unittests|4|1|
>|java-21|5|1|
>|temurin|10|1|
>|integration|6|0|
>|integration1|2|0|
>|java-11|5|0|
>|custom-integration1|2|0|
>|integration2|2|0|
>|unittests1|2|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16590 +/- ##
============================================
- Coverage 63.23% 56.37% -6.87%
+ Complexity 1381 699 -682
============================================
Files 3014 2358 -656
Lines 174699 129893 -44806
Branches 26764 20667 -6097
============================================
- Hits 110470 73222 -37248
+ Misses 55792 50635 -5157
+ Partials 8437 6036 -2401
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <ø> (-6.84%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <ø> (-6.87%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <ø> (-6.87%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <ø> (+0.02%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16590?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Broker: fail fast when broker marked down; keep IdealState/ExternalView checks out of critical path [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #16590:
URL: https://github.com/apache/pinot/pull/16590#discussion_r2274689459
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -622,11 +622,12 @@ private void registerServiceStatusHandler() {
LOGGER.info("Registering service status handler");
ServiceStatus.setServiceStatusCallback(_instanceId, new ServiceStatus.MultipleCallbackServiceStatusCallback(
- ImmutableList.of(new ServiceStatus.IdealStateAndCurrentStateMatchServiceStatusCallback(_participantHelixManager,
+ ImmutableList.of(
Review Comment:
(minor)
```suggestion
List.of(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Broker: fail fast when broker marked down; keep IdealState/ExternalView checks out of critical path [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #16590:
URL: https://github.com/apache/pinot/pull/16590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org