You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:47:54 UTC
[GitHub] [zeppelin] JoWonHyeung opened a new pull request, #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
JoWonHyeung opened a new pull request, #4416:
URL: https://github.com/apache/zeppelin/pull/4416
### What is this PR for?
Even though the user's operating system is windows, 'isWindowsPath' function returns False and enters the else.
Therefore, I think that I need to change isWindowsPath function.
### What type of PR is it?
Bug Fix
### Todos
I replace isWindowsPath Function with isWindowsCheck function. isWindowCheck function uses SystemUtils.IS_OS_WINDOWS
to determine whether the OS is Windows or not. If the user's operating system is windows, It returns true.
### What is the Jira issue?
[](https://issues.apache.org/jira/browse/ZEPPELIN-5773)
### How should this be tested?
CI
### Questions:
* Does the licenses files need to update? No
* Is there breaking changes for older versions? Yes
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4416:
URL: https://github.com/apache/zeppelin/pull/4416#issuecomment-1189885511
@JoWonHyeung Do you plan to create another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] JoWonHyeung closed pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
Posted by GitBox <gi...@apache.org>.
JoWonHyeung closed pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
URL: https://github.com/apache/zeppelin/pull/4416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
Posted by GitBox <gi...@apache.org>.
zjffdu commented on code in PR #4416:
URL: https://github.com/apache/zeppelin/pull/4416#discussion_r924310745
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -327,7 +324,7 @@ public String getServerContextPath() {
public String getKeyStorePath() {
String path = getString(ConfVars.ZEPPELIN_SSL_KEYSTORE_PATH);
- if (path != null && path.startsWith("/") || isWindowsPath(path)) {
+ if (path != null && path.startsWith("/") || isWindowsCheck()) {
Review Comment:
Does just call `SystemUtils.IS_OS_WINDOWS` enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] JoWonHyeung commented on pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class
Posted by GitBox <gi...@apache.org>.
JoWonHyeung commented on PR #4416:
URL: https://github.com/apache/zeppelin/pull/4416#issuecomment-1189906438
Yes, An error occurred in the test and I am looking into it. I will upload it again later. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org