You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Rabi Kumar K C (Jira)" <ji...@apache.org> on 2020/03/18 14:00:14 UTC
[jira] [Comment Edited] (SOLR-14034) remove deprecated min_rf
references
[ https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061718#comment-17061718 ]
Rabi Kumar K C edited comment on SOLR-14034 at 3/18/20, 2:00 PM:
-----------------------------------------------------------------
Hi [~cpoerschke] I am new to solr and want to work on this ticket. I found the usage of UpdateRequest.MIN_REPFACT in DistributedZkUpdateProcessor.java, HttpPartitionTest.java, BaseCloudSolrClient.java, and ReplicationFactorTest.java in the source code. Specifically, in ReplicationFactorTest.java MIN_REPFACT has been used in the following lines:
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L264-268]
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L480]
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L489]
So my question was should I refactor the ReplicationFactorTest.java after removing MIN_REPFACT and keep tests for UpdateRequest.REPFACT or change the MIN_REPFACT into REPFACT?
Please do let me know your thoughts on this or if my question is not clear enough. Thank You
was (Author: rabikumar.kc):
Hi [~cpoerschke] I am new to solr and want to work ontthis ticket. I found the usage of UpdateRequest.MIN_REPFACT in DistributedZkUpdateProcessor.java, HttpPartitionTest.java, BaseCloudSolrClient.java, and ReplicationFactorTest.java in the source code. Specifically, in ReplicationFactorTest.java MIN_REPFACT has been used in the following lines:
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L264-268]
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L480]
* [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L489]
So my question was should I refactor the ReplicationFactorTest.java after removing MIN_REPFACT and keep tests for UpdateRequest.REPFACT or change the MIN_REPFACT into REPFACT?
Please do let me know your thoughts on this or if my question is not clear enough. Thank You
> remove deprecated min_rf references
> -----------------------------------
>
> Key: SOLR-14034
> URL: https://issues.apache.org/jira/browse/SOLR-14034
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Priority: Blocker
> Fix For: master (9.0)
>
>
> * {{min_rf}} support was added under SOLR-5468 in version 4.9 (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.9.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L50) and deprecated under SOLR-12767 in version 7.6 (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.6.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L57-L61)
> * http://lucene.apache.org/solr/7_6_0/changes/Changes.html and https://lucene.apache.org/solr/guide/8_0/major-changes-in-solr-8.html#solr-7-6 both clearly mention the deprecation
> This ticket is to fully remove {{min_rf}} references in code, tests and documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org