You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Vincent Choi (JIRA)" <ji...@apache.org> on 2019/03/27 15:15:00 UTC
[jira] [Commented] (HBASE-22070) Checking restoreDir in
RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802905#comment-16802905 ]
Vincent Choi commented on HBASE-22070:
--------------------------------------
I pushed a simple patch. Could you take a look at it, Please? [~Apache9]
> Checking restoreDir in RestoreSnapshotHelper
> ---------------------------------------------
>
> Key: HBASE-22070
> URL: https://issues.apache.org/jira/browse/HBASE-22070
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.0.0
> Reporter: Vincent Choi
> Priority: Major
> Attachments: HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it with a prefix check "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I think it's more reasonable to chang the code to "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)