You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "michaelsembwever (via GitHub)" <gi...@apache.org> on 2023/04/02 16:21:27 UTC

[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout

michaelsembwever commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155339422


##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr
     @Test
     public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException
     {
-        testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+        testInsertions(randomSeed(), 500, 10, 1, true);

Review Comment:
   the default value of this `tests` parameter is `perThreadTrees * threads`, so we could be replacing values of `1000` with `25600` (where there are 32 availableProcessors). Note in ant we limit this to `2 processors` [here|https://github.com/apache/cassandra/blob/trunk/build.xml#L127] so a value of `1600` (which is still an increase).
   
   is this what you intended @Mmuzaf ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org