[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36599: [SPARK-39228][PYTHON][PS] Implement `skipna` of `Series.argmax`

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #36599:
URL: https://github.com/apache/spark/pull/36599#discussion_r877664483


##########
python/pyspark/pandas/series.py:
##########
@@ -6239,13 +6239,19 @@ def argsort(self) -> "Series":
             ps.concat([psser, self.loc[self.isnull()].spark.transform(lambda _: SF.lit(-1))]),
         )
 
-    def argmax(self) -> int:
+    def argmax(self, skipna: bool = True) -> int:

Review Comment:
   Good point. But I guess it won't be listed in the missing parameters in the documentation (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org