You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "Neilblaze (via GitHub)" <gi...@apache.org> on 2023/02/27 04:46:36 UTC

[GitHub] [apisix] Neilblaze opened a new pull request, #8949: fix: corrected minimum in healthcheck schema

Neilblaze opened a new pull request, #8949:
URL: https://github.com/apache/apisix/pull/8949

   ### Description
   
   It's meaningless to use *zero as the minimum* in [`schema_def.lua`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/apisix/schema_def.lua#L239) which was set to use as a default healthcheck in #5589.
   
   **Fixes #8937** 
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   cc: @spacewander, @navendu-pottekkat 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Neilblaze commented on pull request #8949: fix: corrected minimum in healthcheck schema

Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.

Neilblaze commented on PR #8949:
URL: https://github.com/apache/apisix/pull/8949#issuecomment-1445736895

   @spacewander would you mind having a look at the (nginx) err that I'm facing from the CI test? I noticed that it's specifically because of these two : 
   
   https://github.com/apache/apisix/blob/8d38884a7ac1d08c529e7f8494fa8ea0d01c1872/apisix/core.lua#L21
   
   https://github.com/apache/apisix/blob/8d38884a7ac1d08c529e7f8494fa8ea0d01c1872/apisix/core/config_local.lua#L71
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] github-actions[bot] commented on pull request #8949: fix: corrected minimum in healthcheck schema

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #8949:
URL: https://github.com/apache/apisix/pull/8949#issuecomment-1735228614

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: corrected minimum in healthcheck schema [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.

monkeyDluffy6017 commented on PR #8949:
URL: https://github.com/apache/apisix/pull/8949#issuecomment-1759535250

   hi @Neilblaze, It's designed on purpose, when the configuration is set to 0, it will never report healthy status 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: corrected minimum in healthcheck schema [apisix]

Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.

Neilblaze closed pull request #8949: fix: corrected minimum in healthcheck schema
URL: https://github.com/apache/apisix/pull/8949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: corrected minimum in healthcheck schema [apisix]

Posted by "moonming (via GitHub)" <gi...@apache.org>.

moonming commented on PR #8949:
URL: https://github.com/apache/apisix/pull/8949#issuecomment-1752504459

   @monkeyDluffy6017 please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org