You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/13 06:15:12 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8404:
[WIP][dashboard scoped filter] part 1: scope selector modal
codecov-io edited a comment on issue #8404: [WIP][dashboard scoped filter] part 1: scope selector modal
URL: https://github.com/apache/incubator-superset/pull/8404#issuecomment-545270222
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=h1) Report
> Merging [#8404](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=desc) into [feature--dashboard-scoped-filter](https://codecov.io/gh/apache/incubator-superset/commit/c422b492eb42e8d6ddb85c6d600302e657143642?src=pr&el=desc) will **decrease** coverage by `1.69%`.
> The diff coverage is `53.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature--dashboard-scoped-filter #8404 +/- ##
===================================================================
- Coverage 67.65% 65.95% -1.7%
===================================================================
Files 448 469 +21
Lines 22498 23073 +575
Branches 2364 2468 +104
===================================================================
- Hits 15220 15218 -2
- Misses 7140 7694 +554
- Partials 138 161 +23
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/assets/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeVNlYXJjaC5qc3g=) | `58.65% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Tb3V0aFBhbmUuanN4) | `91.42% <ø> (ø)` | :arrow_up: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeUhpc3RvcnkuanN4) | `83.33% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/components/ModalTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01vZGFsVHJpZ2dlci5qc3g=) | `90% <ø> (ø)` | :arrow_up: |
| [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | `29.16% <ø> (ø)` | :arrow_up: |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `100% <ø> (ø)` | :arrow_up: |
| [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `11.11% <ø> (ø)` | :arrow_up: |
| [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ2hlY2tib3hDb250cm9sLmpzeA==) | `85.71% <ø> (+14.28%)` | :arrow_up: |
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | `22.22% <ø> (ø)` | :arrow_up: |
| ... and [158 more](https://codecov.io/gh/apache/incubator-superset/pull/8404/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=footer). Last update [c422b49...4456fa3](https://codecov.io/gh/apache/incubator-superset/pull/8404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org