You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/10/28 22:30:44 UTC
[jira] Created: (QPID-1408) Managementgen C++ code gets compile
errors on Windows
Managementgen C++ code gets compile errors on Windows
-----------------------------------------------------
Key: QPID-1408
URL: https://issues.apache.org/jira/browse/QPID-1408
Project: Qpid
Issue Type: Bug
Components: Code Generator
Environment: Windows, Visual Studio .NET 2005
Reporter: Steve Huston
Fix For: M4
Attachments: schema.diff
The managementgen-generated schema code gets compile errors on Windows because part of the Windows system header files defines OPTIONAL and that token is also used as a string name in generated code. The attached patch changes the generated OPTIONAL to IS_OPTIONAL to resolve this. It also changes INDEX to IS_INDEX just to keep it consistent with OPTIONAL.
Please review and let me know if it's ok to commit this.
Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1408) Managementgen C++ code gets compile
errors on Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1408:
-------------------------------
Attachment: schema.diff
> Managementgen C++ code gets compile errors on Windows
> -----------------------------------------------------
>
> Key: QPID-1408
> URL: https://issues.apache.org/jira/browse/QPID-1408
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Environment: Windows, Visual Studio .NET 2005
> Reporter: Steve Huston
> Fix For: M4
>
> Attachments: schema.diff
>
>
> The managementgen-generated schema code gets compile errors on Windows because part of the Windows system header files defines OPTIONAL and that token is also used as a string name in generated code. The attached patch changes the generated OPTIONAL to IS_OPTIONAL to resolve this. It also changes INDEX to IS_INDEX just to keep it consistent with OPTIONAL.
> Please review and let me know if it's ok to commit this.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1408) Managementgen C++ code gets compile
errors on Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-1408.
--------------------------------
Resolution: Fixed
Assignee: Steve Huston
Thanks very much for the quick response, Ted. Committed to svn revision 708704
> Managementgen C++ code gets compile errors on Windows
> -----------------------------------------------------
>
> Key: QPID-1408
> URL: https://issues.apache.org/jira/browse/QPID-1408
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Environment: Windows, Visual Studio .NET 2005
> Reporter: Steve Huston
> Assignee: Steve Huston
> Fix For: M4
>
> Attachments: schema.diff
>
>
> The managementgen-generated schema code gets compile errors on Windows because part of the Windows system header files defines OPTIONAL and that token is also used as a string name in generated code. The attached patch changes the generated OPTIONAL to IS_OPTIONAL to resolve this. It also changes INDEX to IS_INDEX just to keep it consistent with OPTIONAL.
> Please review and let me know if it's ok to commit this.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1408) Managementgen C++ code gets compile
errors on Windows
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643350#action_12643350 ]
Ted Ross commented on QPID-1408:
--------------------------------
Steve,
This looks good. Ok to commit.
Thanks,
-Ted
> Managementgen C++ code gets compile errors on Windows
> -----------------------------------------------------
>
> Key: QPID-1408
> URL: https://issues.apache.org/jira/browse/QPID-1408
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Environment: Windows, Visual Studio .NET 2005
> Reporter: Steve Huston
> Fix For: M4
>
> Attachments: schema.diff
>
>
> The managementgen-generated schema code gets compile errors on Windows because part of the Windows system header files defines OPTIONAL and that token is also used as a string name in generated code. The attached patch changes the generated OPTIONAL to IS_OPTIONAL to resolve this. It also changes INDEX to IS_INDEX just to keep it consistent with OPTIONAL.
> Please review and let me know if it's ok to commit this.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.