[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3383: Make running profile clearer and more intuitive to improve usability (#3365)

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #3383:
URL: https://github.com/apache/incubator-doris/pull/3383#discussion_r414257609



##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -1038,6 +1038,7 @@ Status OlapScanNode::normalize_binary_predicate(SlotDescriptor* slot, ColumnValu
 
 void OlapScanNode::transfer_thread(RuntimeState* state) {
     // scanner open pushdown to scanThread
+    state->resource_pool()->acquire_thread_token();

Review comment:
       Add this operation just to Make AverageThreadTokens more accurate
      - AverageThreadTokens: 1.00  
   
   Do not warry thread hang on this operation。
   acquire_thread_token() just do a lightweight add operation without doing the really thread assignment 
   
   inline void ThreadResourceMgr::ResourcePool::acquire_thread_token() {
       __sync_fetch_and_add(&_num_threads, 1);
   }
   
   @imay
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org