You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2018/12/11 00:40:57 UTC

[mynewt-newt] 02/03: Don't automatically capitalize syscfg names

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git

commit f44cfd9031db125cd80d1bc2ed9d33dddc00f34b
Author: Christopher Collins <cc...@apache.org>
AuthorDate: Thu Dec 6 17:13:52 2018 -0800

    Don't automatically capitalize syscfg names
    
    Prior to this commit, newt always capitalized all syscfg setting names.
    This interferes with some injected settings (app name, BSP name, etc.).
    
    Now, newt leaves setting name capitalization unchanged.
---
 newt/syscfg/syscfg.go | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/newt/syscfg/syscfg.go b/newt/syscfg/syscfg.go
index 40f68b3..8a81a68 100644
--- a/newt/syscfg/syscfg.go
+++ b/newt/syscfg/syscfg.go
@@ -998,12 +998,8 @@ func (cfg *Cfg) DeprecatedWarning() []string {
 	return lines
 }
 
-func escapeStr(s string) string {
-	return strings.ToUpper(util.CIdentifier(s))
-}
-
 func settingName(setting string) string {
-	return SYSCFG_PREFIX_SETTING + escapeStr(setting)
+	return SYSCFG_PREFIX_SETTING + util.CIdentifier(setting)
 }
 
 func normalizePkgType(typ interfaces.PackageType) interfaces.PackageType {