You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/29 11:13:49 UTC

[GitHub] [airflow] potiuk commented on pull request #9563: Use update instead of merge in _run_raw_task

potiuk commented on pull request #9563:
URL: https://github.com/apache/airflow/pull/9563#issuecomment-651045892


   I think it depends - indeed we are trading-of a bit of performance for the explicit query. I am personally in favour of being more explicit (like in python's Zen) of what's going on - especially that this is really what happens here - we expect to only update those values. And actually I find it a bit easier to reason on what's going on here rather than rely on "whatever happens to the object, let's merge it here).  But this is not a super-strong opinion and I am ok with either.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org