You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "singhpk234 (via GitHub)" <gi...@apache.org> on 2023/04/23 07:36:12 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request, #7414: Spark: Fix failing SS UT
singhpk234 opened a new pull request, #7414:
URL: https://github.com/apache/iceberg/pull/7414
### About the change
As part of implementing `SupportsAdmissionControl` we now implement `Offset latestOffset(Offset startOffset, ReadLimit limit);` it faces the same problem as here https://github.com/apache/iceberg/pull/6480 , this change now throws an IllegalStateException instead of NPE and the ci for rate-limit pr had not run been rebased and re-run this couldn't be caught.
This pr attempts to fix the issue by having the similar handling.
### Testing
failing ut's pass now
cc @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7414: Spark: Fix failing SS UT
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7414:
URL: https://github.com/apache/iceberg/pull/7414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7414: Spark: Fix failing SS UT
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7414:
URL: https://github.com/apache/iceberg/pull/7414#issuecomment-1518983969
Thanks for the quick fix! Will merge asap after CI passes to unblock other people
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org