You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/11 17:07:12 UTC
Review Request 71059: Added consumed quota, allocated, reserved,
offered to the roles table.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71059/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Andrei Sekretenko, and Meng Zhu.
Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789
Repository: mesos
Description
-------
This adds resource breakdowns on a per role basis to the roles table
in the webui, each column except for the role name is selectable to
allow the user to tune the view for their needs.
Diffs
-----
src/webui/app/controllers.js 42a9fb657e98bbd57265f2c9cf8e4d1013d3f271
src/webui/app/roles/roles.html 45e2a332e62e072e97fc97ab3945ff65ad942ddf
Diff: https://reviews.apache.org/r/71059/diff/1/
Testing
-------
See attached gif.
File Attachments
----------------
demo
https://reviews.apache.org/media/uploaded/files/2019/07/11/44987278-1415-4e55-a36f-2fb299d930e0__roles-table-selectable-columns2.gif
Thanks,
Benjamin Mahler
Re: Review Request 71059: Added consumed quota, allocated, reserved,
offered to the roles table.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71059/#review216535
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71060, 71050, 71051, 71052, 71053, 71059]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 11, 2019, 5:07 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71059/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 5:07 p.m.)
>
>
> Review request for mesos, Armand Grillet, Andrei Sekretenko, and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds resource breakdowns on a per role basis to the roles table
> in the webui, each column except for the role name is selectable to
> allow the user to tune the view for their needs.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 42a9fb657e98bbd57265f2c9cf8e4d1013d3f271
> src/webui/app/roles/roles.html 45e2a332e62e072e97fc97ab3945ff65ad942ddf
>
>
> Diff: https://reviews.apache.org/r/71059/diff/1/
>
>
> Testing
> -------
>
> See attached gif.
>
>
> File Attachments
> ----------------
>
> demo
> https://reviews.apache.org/media/uploaded/files/2019/07/11/44987278-1415-4e55-a36f-2fb299d930e0__roles-table-selectable-columns2.gif
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71059: Added consumed quota, allocated, reserved,
offered to the roles table.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 11, 2019, 9:37 p.m., Meng Zhu wrote:
> > src/webui/app/roles/roles.html
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/71059/diff/1/?file=2154527#file2154527line31>
> >
> > Plural? ditto below
These just match the column names, are you suggesting pluralizing both?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71059/#review216539
-----------------------------------------------------------
On July 11, 2019, 5:07 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71059/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 5:07 p.m.)
>
>
> Review request for mesos, Armand Grillet, Andrei Sekretenko, and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds resource breakdowns on a per role basis to the roles table
> in the webui, each column except for the role name is selectable to
> allow the user to tune the view for their needs.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 42a9fb657e98bbd57265f2c9cf8e4d1013d3f271
> src/webui/app/roles/roles.html 45e2a332e62e072e97fc97ab3945ff65ad942ddf
>
>
> Diff: https://reviews.apache.org/r/71059/diff/1/
>
>
> Testing
> -------
>
> See attached gif.
>
>
> File Attachments
> ----------------
>
> demo
> https://reviews.apache.org/media/uploaded/files/2019/07/11/44987278-1415-4e55-a36f-2fb299d930e0__roles-table-selectable-columns2.gif
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71059: Added consumed quota, allocated, reserved,
offered to the roles table.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71059/#review216539
-----------------------------------------------------------
Ship it!
Very nice!!
src/webui/app/roles/roles.html
Lines 31 (patched)
<https://reviews.apache.org/r/71059/#comment303750>
Plural? ditto below
src/webui/app/roles/roles.html
Lines 34 (patched)
<https://reviews.apache.org/r/71059/#comment303751>
Plural? Ditto below
- Meng Zhu
On July 11, 2019, 10:07 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71059/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 10:07 a.m.)
>
>
> Review request for mesos, Armand Grillet, Andrei Sekretenko, and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds resource breakdowns on a per role basis to the roles table
> in the webui, each column except for the role name is selectable to
> allow the user to tune the view for their needs.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 42a9fb657e98bbd57265f2c9cf8e4d1013d3f271
> src/webui/app/roles/roles.html 45e2a332e62e072e97fc97ab3945ff65ad942ddf
>
>
> Diff: https://reviews.apache.org/r/71059/diff/1/
>
>
> Testing
> -------
>
> See attached gif.
>
>
> File Attachments
> ----------------
>
> demo
> https://reviews.apache.org/media/uploaded/files/2019/07/11/44987278-1415-4e55-a36f-2fb299d930e0__roles-table-selectable-columns2.gif
>
>
> Thanks,
>
> Benjamin Mahler
>
>