[GitHub] [pinot] jackjlli commented on a diff in pull request #9681: Close Filesystem on exit with Minion Tasks

[GitBox <gi...@apache.org>]

jackjlli commented on code in PR #9681:
URL: https://github.com/apache/pinot/pull/9681#discussion_r1008312355


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskUtils.java:
##########
@@ -50,7 +49,7 @@ static PinotFS getInputPinotFS(Map<String, String> taskConfigs, URI fileURI)
       return pinotFS;
     }
     // Fallback to use the PinotFS created by Minion Server configs
-    return PinotFSFactory.create(fileURIScheme);
+    return null;

Review Comment:
   Should we update the comment 1 line above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org