[GitHub] [hive] belugabehr commented on a change in pull request #1963: HIVE-24758: Log Tez Task DAG ID, DAG Session ID, HS2 Hostname

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #1963:
URL: https://github.com/apache/hive/pull/1963#discussion_r573064500



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
##########
@@ -351,6 +356,17 @@ private String getUserNameForGroups(SessionState ss) {
     return ss.getUserName();
   }
 
+  private static String getHostNameIP() {
+    try {
+      InetAddress ip = InetAddress.getLocalHost();
+      String hostname = ip.getHostName();
+      return String.format("%s (%s)", hostname, ip.getHostAddress());
+    } catch (UnknownHostException e) {
+      LOG.debug("Unable to determine hostname", e);

Review comment:
       @miklosgergely The issue here is that anything that logs to this logger gets forwarded to the user's connection.  I don't want to print errors and stack traces to their connection.  If user starts getting "unknown" responses, they can enable debug logging and get it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org