You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/21 14:09:27 UTC
[GitHub] [buildstream] abderrahim opened a new issue, #1693: remove `index` and `storage` artifact/source cache type
abderrahim opened a new issue, #1693:
URL: https://github.com/apache/buildstream/issues/1693
Once upon a time, we had a non-standard API for storing artifact information. However, we now use the remote asset API which is part of the remote execution APIs. We no longer need to have separate index and storage for the cache.
Even for implementations that separate the CAS and remote asset, we can just push the responsibility to whoever is deploying it to just add a traefik proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on issue #1693: remove `index` and `storage` artifact/source cache type
Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1693:
URL: https://github.com/apache/buildstream/issues/1693#issuecomment-1192171159
Right now the client has the ability to deal with setups where the `AssetCache` is separate from the `CAS`, which I think is nice to keep.
Also our API is stable since our last beta, so we can't rightly remove this.
That said, it can be an interesting feature to add which allows the client to communicate with the same URI configuration for both pushing and pulling.
But there is one really big problem with adding such a new feature... looking at the code right now, it appears that the feature is already supported :-/
It is called the `all` type: https://docs.buildstream.build/master/using_config.html#cache-servers ... and in fact it is the default, so if you specify a cache server and neglect to specify the `type`, it is assumed to be usable for both indexing and storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on issue #1693: remove `index` and `storage` artifact/source cache type
Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1693:
URL: https://github.com/apache/buildstream/issues/1693#issuecomment-1217704271
Let's close this as it is an API break and there does not seem to be an urgent reason to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on issue #1693: remove `index` and `storage` artifact/source cache type
Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1693:
URL: https://github.com/apache/buildstream/issues/1693#issuecomment-1192293694
It’s a clear API break, afaics that ship has sailed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on issue #1693: remove `index` and `storage` artifact/source cache type
Posted by GitBox <gi...@apache.org>.
abderrahim commented on issue #1693:
URL: https://github.com/apache/buildstream/issues/1693#issuecomment-1192248624
Indeed, this is not about adding a feature but rather about removing one. I don't think it is useful, and it would be nice to not have to support it. For instance, it is the main reason we still have bst-artifact-server for the tests.
Either way, this needs to be discussed with the other developers and would be either a blocker or a "won't fix".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed issue #1693: remove `index` and `storage` artifact/source cache type
Posted by GitBox <gi...@apache.org>.
gtristan closed issue #1693: remove `index` and `storage` artifact/source cache type
URL: https://github.com/apache/buildstream/issues/1693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org