You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/01/23 07:04:22 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request #891: feat(build): support to build on MacOS
acelyc111 opened a new pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891
ref issue: https://github.com/apache/incubator-pegasus/issues/813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#discussion_r790385896
##########
File path: src/server/hashkey_transform.h
##########
@@ -46,7 +47,7 @@ class HashkeyTransform : public rocksdb::SliceTransform
}
// hash_key_len is in big endian
- uint16_t hash_key_len = be16toh(*(int16_t *)(src.data()));
+ uint16_t hash_key_len = ::dsn::endian::ntoh(*(uint16_t *)(src.data()));
Review comment:
::dsn::endian::ntoh --> dsn::endian::ntoh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 merged pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#issuecomment-1020777419
> Is it possible to add CI step for MACOS?
We can do it in the next step, similar to how rocksdb do, https://github.com/facebook/rocksdb/blob/7711f8cbb42dd96111a133099b029b6fabff6f48/.circleci/config.yml#L167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
Smityz commented on pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#issuecomment-1020750728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#issuecomment-1020777419
> Is it possible to add CI step for MACOS?
We can do it in the next step, similar to how rocksdb do, https://github.com/facebook/rocksdb/blob/7711f8cbb42dd96111a133099b029b6fabff6f48/.circleci/config.yml#L167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
Smityz commented on pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#issuecomment-1020752200
Is it possible to add CI step for MACOS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on pull request #891: feat(build): support to build on MacOS
Posted by GitBox <gi...@apache.org>.
Smityz commented on pull request #891:
URL: https://github.com/apache/incubator-pegasus/pull/891#issuecomment-1020750728
Great job, after this PR merged, could you update the document on this page?
https://pegasus.apache.org/docs/build/compile-from-source/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org