You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/12 11:37:40 UTC

[GitHub] [airflow] shahkshitij15 opened a new pull request #22202: Added autodetect arg to Create External Table Operator

shahkshitij15 opened a new pull request #22202:
URL: https://github.com/apache/airflow/pull/22202


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #22129
   related: #22129 
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Added autodetect argument to BigQueryCreateExternalTable Operator 
   ---
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #22202: Added autodetect arg to Create External Table Operator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22202:
URL: https://github.com/apache/airflow/pull/22202#issuecomment-1066023351


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #22202: Added autodetect arg to Create External Table Operator

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22202:
URL: https://github.com/apache/airflow/pull/22202#issuecomment-1073236805


   @shahkshitij15 can you please fix failing test?
   https://github.com/apache/airflow/runs/5612449295?check_suite_focus=true#step:9:3155
   ```
    ==================================== ERRORS ====================================
     _ ERROR collecting tests/providers/google/firebase/operators/test_firestore_system.py _
     tests/providers/google/firebase/operators/test_firestore_system.py:20: in <module>
         from airflow.providers.google.firebase.example_dags.example_firestore import (
     airflow/providers/google/firebase/example_dags/example_firestore.py:119: in <module>
         "csvOptions": {"skipLeadingRows": 1},
     airflow/models/baseoperator.py:386: in apply_defaults
         result = func(self, **kwargs, default_args=default_args)
     airflow/providers/google/cloud/operators/bigquery.py:1111: in __init__
         raise ValueError("You provided both `table_resource` and exclusive keywords arguments.")
     E   ValueError: You provided both `table_resource` and exclusive keywords arguments.
     =============================== warnings summary ===============================
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org