You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2014/02/10 20:47:18 UTC

Review Request 17915: FLUME-2307. Remove Log writeTimeout

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17915/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2307
    https://issues.apache.org/jira/browse/FLUME-2307


Repository: flume-git


Description
-------

Remove Log writeTimeout.


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 2cd7f03 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 70106cb 

Diff: https://reviews.apache.org/r/17915/diff/


Testing
-------

All current tests pass


Thanks,

Hari Shreedharan

Re: Review Request 17915: FLUME-2307. Remove Log writeTimeout

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17915/#review34101
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Feb. 10, 2014, 8 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17915/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 8 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2307
>     https://issues.apache.org/jira/browse/FLUME-2307
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Remove Log writeTimeout.
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 2cd7f03 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 10ca11f 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 70106cb 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst d120a74 
> 
> Diff: https://reviews.apache.org/r/17915/diff/
> 
> 
> Testing
> -------
> 
> All current tests pass
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request 17915: FLUME-2307. Remove Log writeTimeout

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17915/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 8 p.m.)


Review request for Flume.


Changes
-------

Removed checkpoint write timeout too. Removed the configuration parameters and removed the parameters from the documentation


Bugs: FLUME-2307
    https://issues.apache.org/jira/browse/FLUME-2307


Repository: flume-git


Description
-------

Remove Log writeTimeout.


Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 2cd7f03 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 10ca11f 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 70106cb 
  flume-ng-doc/sphinx/FlumeUserGuide.rst d120a74 

Diff: https://reviews.apache.org/r/17915/diff/


Testing
-------

All current tests pass


Thanks,

Hari Shreedharan