[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377101138
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/statement/dal/DALStatementAssert.java
 ##########
 @@ -83,6 +86,8 @@ public static void assertIs(final SQLCaseAssertContext assertContext, final DALS
             ShowTableStatusStatementAssert.assertIs(assertContext, (ShowTableStatusStatement) actual, (ShowTableStatusStatementTestCase) expected);
         } else if (actual instanceof ShowIndexStatement) {
             ShowIndexStatementAssert.assertIs(assertContext, (ShowIndexStatement) actual, (ShowIndexStatementTestCase) expected);
+        } else if (actual instanceof SetStatement) {
 
 Review comment:
   `SetStatement` is a new type with `ShowXXXStatement`, it should not between `ShowIndexStatement` and `ShowStatement`, please move `SetStatement` behind `ShowStatement`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services