You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/23 08:25:35 UTC
[PR] fix(test): isolate e2e suites by unique workflow/execution id (#5888) [release/v1.2 backport] [texera]
Ma77Ball opened a new pull request, #5903:
URL: https://github.com/apache/texera/pull/5903
### What changes were proposed in this PR?
- Backport of #5888 to `release/v1.2`, applied as `git cherry-pick -x 8803d084c`.
- Each amber e2e suite now gets a distinct id via a new `TestUtils.workflowContext(id, ...)` helper (DataProcessingSpec=1, PauseSpec=2, ReconfigurationSpec=3, ReconfigurationIntegrationSpec=4), and the DB fixture rows (user/workflow/version/execution, plus a per-id email) are derived from that id, so concurrent suites no longer collide in the shared Iceberg keyspace.
- One conflict resolved, in `TestUtils.scala` imports only: kept release/v1.2's `org.apache.texera.amber.config.StorageConfig` path and took the cherry-pick's added `ExecutionIdentity`/`WorkflowIdentity`/`WorkflowSettings` imports needed by the new helper. The four spec files applied cleanly.
- The `runWorkflowAndReadTerminalResults`/`readMaterializedResults` helpers that exist on `main` came from a separate change not on `release/v1.2`; #5888 does not touch them, so they are correctly absent here.
### Any related issues, documentation, discussions?
Closes: #5902
### How was this PR tested?
- Behavior is unchanged from #5888 (test-only isolation), so it relies on the existing e2e suites carried over verbatim. Reviewer can run them in the integration job: `sbt "amber/IntegrationTest/testOnly *ReconfigurationIntegrationSpec"`, and the unit e2e suites via `sbt "amber/testOnly *DataProcessingSpec *PauseSpec *ReconfigurationSpec"`; expect all green with no Iceberg `CommitFailedException` keyspace collisions across concurrently-running suites.
- Local `sbt` could not load on `release/v1.2` (its `project/` lacks `AddMetaInfLicenseFiles`, unrelated to this change), so full compile/test is left to CI on this PR.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(test): isolate e2e suites by unique workflow/execution id [release/v1.2 backport] [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5903:
URL: https://github.com/apache/texera/pull/5903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(test): isolate e2e suites by unique workflow/execution id (#5888) [release/v1.2 backport] [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5903:
URL: https://github.com/apache/texera/pull/5903#issuecomment-4777517401
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Yicong-Huang`
You can notify them by mentioning `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(test): isolate e2e suites by unique workflow/execution id (#5888) [release/v1.2 backport] [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5903:
URL: https://github.com/apache/texera/pull/5903#issuecomment-4777718270
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5903?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 51.98%. Comparing base ([`c39e99b`](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0f6b9a9`](https://app.codecov.io/gh/apache/texera/commit/0f6b9a9594fea5c2a0fd57e5981133a6105b8f34?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release/v1.2 #5903 +/- ##
===============================================
Coverage 51.98% 51.98%
Complexity 2480 2480
===============================================
Files 1065 1065
Lines 41290 41290
Branches 4420 4420
===============================================
Hits 21464 21464
Misses 18565 18565
Partials 1261 1261
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.61% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.20% <ø> (ø)` | | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.59% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.31% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.77% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.75% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [c39e99b](https://app.codecov.io/gh/apache/texera/commit/c39e99b6289ce4c3723b7048d6b431e767a01476?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5903?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(test): isolate e2e suites by unique workflow/execution id (#5888) [release/v1.2 backport] [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5903:
URL: https://github.com/apache/texera/pull/5903#issuecomment-4777247248
/request-review @xuang7 @Yicong-Huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org