You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ibilley7 (via GitHub)" <gi...@apache.org> on 2025/08/15 18:10:53 UTC
[PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
ibilley7 opened a new pull request, #5803:
URL: https://github.com/apache/accumulo/pull/5803
Changed these properties to be non-fixed (made no-fixed by creating a thread pool in the run method of Manager that "refresh" these properties on an interval):
* `MANAGER_TABLET_REFRESH_MINTHREADS`
* `MANAGER_TABLET_REFRESH_MAXTHREADS`
Removed these non-fixed properties that were labeled as fixed:
* `MANAGER_MINTHREADS`
* `SSERV_MINTHREADS`
* 'TSERV_MINTHREADS'
* `COMPACTOR_MINTHREADS`
All of the other properties in FIXED_PROPERTIES besides these need to be evaluated similarly in another PR.
Partial work for #5696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "ibilley7 (via GitHub)" <gi...@apache.org>.
ibilley7 commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3201746106
I noticed that the `resizePool()` method resizes based on the maxThread property, and that when it's changed, the minThreads property is also changed to that new size in this code
```
if (newCount > count) {
// increasing, increase the max first, or the core will fail to be increased
pool.setMaximumPoolSize(newCount);
pool.setCorePoolSize(newCount);
} else {
// decreasing, lower the core size first, or the max will fail to be lowered
pool.setCorePoolSize(newCount);
pool.setMaximumPoolSize(newCount);
}
```
Does that mean in the new `resizePool()` method I create for minThreads that when the CorePoolSize is changed, it would set the MaximumPoolSize to the same new value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "ibilley7 (via GitHub)" <gi...@apache.org>.
ibilley7 commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3214468979
My internship is over, so I would need someone to pick up this ticket if more work needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "ibilley7 (via GitHub)" <gi...@apache.org>.
ibilley7 commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3201499890
So would you recommend using the resizePool method, or just more so modeling the code based off of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3201567088
> So would you recommend using the resizePool method, or just more so modeling the code based off of it?
I would recommend reusing it if you can. If there is something that you need that it's not currently doing, then lets fix it or add a new `resizePool` method in `ThreadPools`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3201863900
> I noticed that the resizePool() method resizes based on the maxThread property, and that when it's changed, the minThreads property is also changed to that new size in this code:
Right, this was the logic that I was mentioning. IIRC we had to modify the core/max in a specific order based on the JDK internal code at that time. The current code just resizes based on the max size property IIRC because I don't think we resize based on the min/core size. You are trying to do something a little different than what we have done in the past, so you likely need a new method to resize the core and max independently, but might need to retain some of the logic from the existing resizePool method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert properties in FIXED_PROPERTIES to be non-fixed [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5803:
URL: https://github.com/apache/accumulo/pull/5803#issuecomment-3198239483
Please take a look at `ThreadPools.resizePool`. We have some logic there that you can call from the refresh thread in the Manager. I'm not sure if fully covers what you are trying to here, but I know it partially does. Also, please use the Logger object instead of printing to System.out / System.err. We only do that in certain circumstances, like in utility code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org