You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/06/11 08:17:35 UTC
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17583
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
IMPALA-9659: [DOCS] Document supported distros
Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
---
M README.md
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/17583/1
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
IMPALA-9659: [DOCS] Document supported distros
Our Requirements docuemnt points to the README.md about supported
distros:
https://impala.apache.org/docs/build/html/topics/impala_prereqs.html
However, README.md doesn't mention is. This patch adds a section for
this.
Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Reviewed-on: http://gerrit.cloudera.org:8080/17583
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M README.md
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:24:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17583/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17583/2//COMMIT_MSG@9
PS2, Line 9: docuemnt
document
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55
PS2, Line 55: SLES12
Is this noted anywhere else? I'm trying to find it in the code or docs, partially to help me understand what we mean when we say "supported".
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 12:44:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:31:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55
PS2, Line 55:
> SGTM; ty!
Done
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 18 Jul 2021 01:25:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55
PS2, Line 55: SLES12
> Good question. I just know that CDP/CDH supports SLES12 so Impala supports
SGTM; ty!
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 01:11:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9110/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 18 Jul 2021 01:52:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17583
to look at the new patch set (#3).
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
IMPALA-9659: [DOCS] Document supported distros
Our Requirements docuemnt points to the README.md about supported
distros:
https://impala.apache.org/docs/build/html/topics/impala_prereqs.html
However, README.md doesn't mention is. This patch adds a section for
this.
Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
---
M README.md
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/17583/3
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 18 Jul 2021 01:29:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8895/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 08:38:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17583
to look at the new patch set (#2).
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
IMPALA-9659: [DOCS] Document supported distros
Our Requirements docuemnt points to the README.md about supported
distros:
https://impala.apache.org/docs/build/html/topics/impala_prereqs.html
However, README.md doesn't mention is. This patch adds a section for
this.
Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
---
M README.md
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/17583/2
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55
PS2, Line 55: SLES12
> Is this noted anywhere else? I'm trying to find it in the code or docs, par
Good question. I just know that CDP/CDH supports SLES12 so Impala supports it, i.e. have test coverage on it. I'm going to remove this and mention that other systems may also be supported but are not tested by the community. Do you think it's ok?
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 00:37:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 )
Change subject: IMPALA-9659: [DOCS] Document supported distros
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/373/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:24:28 +0000
Gerrit-HasComments: No