[jira] [Resolved] (BEAM-3081) Our findbugs config does not actually use Nullable annotations effectively

["Kenneth Knowles (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles resolved BEAM-3081.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

I'm satisfied that enough precedent exists. We could take it further and test that every package-info.java has the proper annotation but it is diminishing returns at this point.

> Our findbugs config does not actually use Nullable annotations effectively
> --------------------------------------------------------------------------
>
>                 Key: BEAM-3081
>                 URL: https://issues.apache.org/jira/browse/BEAM-3081
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>             Fix For: Not applicable
>
>
> We use {{@Nullable}} annotations mostly appropriately, but in fact our findbugs config was not delivering value based on these annotations, because it does not default to {{@NonNull}}. We can and should set this default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)