You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2011/03/15 21:19:29 UTC
Re: svn commit: r1081921 - in /trafficserver/traffic/trunk/lib/tsconfig: Makefile.am TsBuilder.cc TsErrataUtil.cc test-1.tsconfig test-tsconfig.cc
----- Original Message -----
> Author: amc
> Date: Tue Mar 15 20:04:53 2011
> New Revision: 1081921
>
> URL: http://svn.apache.org/viewvc?rev=1081921&view=rev
> Log:
> TS-708
>
> Added:
> trafficserver/traffic/trunk/lib/tsconfig/test-1.tsconfig
> trafficserver/traffic/trunk/lib/tsconfig/test-tsconfig.cc
> Modified:
> trafficserver/traffic/trunk/lib/tsconfig/Makefile.am
> trafficserver/traffic/trunk/lib/tsconfig/TsBuilder.cc
> trafficserver/traffic/trunk/lib/tsconfig/TsErrataUtil.cc
>
> Modified: trafficserver/traffic/trunk/lib/tsconfig/Makefile.am
> URL:
> http://svn.apache.org/viewvc/trafficserver/traffic/trunk/lib/tsconfig/Makefile.am?rev=1081921&r1=1081920&r2=1081921&view=diff
> ==============================================================================
> --- trafficserver/traffic/trunk/lib/tsconfig/Makefile.am (original)
> +++ trafficserver/traffic/trunk/lib/tsconfig/Makefile.am Tue Mar 15
> 20:04:53 2011
> @@ -17,11 +17,13 @@
> # limitations under the License.
>
> noinst_LIBRARIES = libtsconfig.a
> +noinst_PROGRAMS = test-tsconfig
>
> AM_YFLAGS = -d -p tsconfig
>
> AM_CPPFLAGS = \
> - -I$(top_srcdir)/lib
> + -I$(top_srcdir)/lib \
> + -fPIC
This seems out of place here.
Shouldn't it depend on pic_mode?
Aside from that, -fPIC is non-portable either
But this isn't the only place where we can find it:
i.galic@panic ~/Projects/asf/trafficserver (svn)-[trunk:1081925] % ack -li 'fpic|fpie' **/* | sort -u
build/tcl.m4
configure.ac
lib/tsconfig/Makefile.am
test/plugin/Makefile.am
test/SDKtest/client/api/Makefile.am
test/SDKtest/synth_server/api/Makefile.am
tools/tsxs.in
However, we can ignore the .m4 and the .ac and the tsxs.in.
Given that test/ is outdated, this only leaves us with
lib/tsconfig/Makefile.am
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/