[jira] [Commented] (FLINK-7163) Make LogicalTableFunctionCall immutable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083690#comment-16083690 ] 

ASF GitHub Bot commented on FLINK-7163:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/4308

    [FLINK-7163] Make LogicalTableFunctionCall immutable

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-7163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4308
    
----
commit a297e12cb3750012d04261a98ba67e6695d77a82
Author: Xpray <le...@gmail.com>
Date:   2017-07-12T09:17:11Z

    [FLINK-7163] Make LogicalTableFunctionCall immutable

----


> Make LogicalTableFunctionCall immutable
> ---------------------------------------
>
>                 Key: FLINK-7163
>                 URL: https://issues.apache.org/jira/browse/FLINK-7163
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> All sub-classes of LogicalNode are immutable except for `LogicalTableFunctionCall`, it's better to make LogicalTableFunctionCall immutable



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)