You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2007/04/26 13:52:15 UTC

svn commit: r532716 - /lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java

Author: andreas
Date: Thu Apr 26 04:52:13 2007
New Revision: 532716

URL: http://svn.apache.org/viewvc?view=rev&rev=532716
Log:
Forward revision parameter from the DocumentSourceFactory to the RepositorySourceFactory. This is a part of the fix for bug 42242.

Modified:
    lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java

Modified: lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java?view=diff&rev=532716&r1=532715&r2=532716
==============================================================================
--- lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java (original)
+++ lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java Thu Apr 26 04:52:13 2007
@@ -136,6 +136,13 @@
             LinkTarget target = resolver.resolve(currentDoc, linkUri);
             Document doc = target.getDocument();
 
+            if (target.isRevisionSpecified()) {
+                if (queryString == null) {
+                    queryString = "";
+                }
+                queryString += "rev=" + target.getRevisionNumber();
+            }
+
             String format = null;
             if (queryString != null) {
                 Query query = new Query(queryString);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org


Re: svn commit: r532716 - /lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java

Posted by Andreas Hartmann <an...@apache.org>.
Jörn Nettingsmeier schrieb:
> andreas@apache.org wrote:
>> Author: andreas
>> Date: Thu Apr 26 04:52:13 2007
>> New Revision: 532716
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=532716
>> Log:
>> Forward revision parameter from the DocumentSourceFactory to the
>> RepositorySourceFactory. This is a part of the fix for bug 42242.
> 
> works for me now. revisions are displayed properly.
> one issue, though: BXE seems to generate two revisions for each "save
> and exit", a second apart. can anybody confirm this?
> bug or feature?

I guess it's a bug. Would you mind filing it? TIA!

-- Andreas

> if the latter, how do i switch it off?
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r532716 - /lenya/trunk/src/modules-core/linking/java/src/org/apache/lenya/cms/cocoon/source/DocumentSourceFactory.java

Posted by Jörn Nettingsmeier <ne...@apache.org>.
andreas@apache.org wrote:
> Author: andreas
> Date: Thu Apr 26 04:52:13 2007
> New Revision: 532716
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=532716
> Log:
> Forward revision parameter from the DocumentSourceFactory to the RepositorySourceFactory. This is a part of the fix for bug 42242.

works for me now. revisions are displayed properly.
one issue, though: BXE seems to generate two revisions for each "save 
and exit", a second apart. can anybody confirm this?
bug or feature? if the latter, how do i switch it off?




-- 
Jörn Nettingsmeier

Kurt is up in heaven now.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org