You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "LiJie20190102 (via GitHub)" <gi...@apache.org> on 2023/05/19 09:26:50 UTC

[GitHub] [dolphinscheduler] LiJie20190102 opened a new pull request, #14153: [Fix-13480][Resource] When downloading a file, an error will occur when uploading the file

LiJie20190102 opened a new pull request, #14153:
URL: https://github.com/apache/dolphinscheduler/pull/14153

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   ## Purpose of the pull request
   
   ref #13480 
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   
   Added org.apache.dolphinscheduler.service.storage.impl.OssOperatorTest#testUpload
   Added org.apache.dolphinscheduler.service.storage.impl.OssOperatorTest#testDownload
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS closed pull request #14153: [Fix-13480][Resource] When downloading a file, an error will occur when uploading the file

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #14153: [Fix-13480][Resource] When downloading a file, an error will occur when uploading the file
URL: https://github.com/apache/dolphinscheduler/pull/14153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] LiJie20190102 commented on pull request #14153: [Fix-13480][Resource] When downloading a file, an error will occur when uploading the file

Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #14153:
URL: https://github.com/apache/dolphinscheduler/pull/14153#issuecomment-1554295623

   Previous PR #14042 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #14153: [Fix-13480][Resource] When downloading a file, an error will occur when uploading the file

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #14153:
URL: https://github.com/apache/dolphinscheduler/pull/14153#issuecomment-1554300630

   Agreed with @Radeity in https://github.com/apache/dolphinscheduler/pull/14042#issuecomment-1543404705.
   
   I don't think ds needs to restrict the functionality of third-party storage since it's it is a scheduling system, not a storage system.
   
   I'll close this PR. Feel free to continue disscussing it in the issue #13480.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org