[GitHub] [tvm] mehrdadh commented on a diff in pull request #13313: [microTVM][CRT] Add memory size as project option

[GitBox <gi...@apache.org>]

mehrdadh commented on code in PR #13313:
URL: https://github.com/apache/tvm/pull/13313#discussion_r1016038634


##########
src/runtime/crt/host/microtvm_api_server.py:
##########
@@ -67,6 +88,29 @@ def server_info_query(self, tvm_version):
     # The build target given to make
     BUILD_TARGET = "build/main"
 
+    def _populate_makefile(
+        self,
+        makefile_template_path: pathlib.Path,
+        makefile_path: pathlib.Path,
+        memory_size: int,

Review Comment:
   I'd rather this way because it makes it clear at high level APIs, like generate_project, what are the requirement for each option. If we pass `options` to sub-functions, we need to check multiple levels to determine if each option is required/option for each API call.



##########
src/runtime/crt/host/microtvm_api_server.py:
##########
@@ -57,7 +71,14 @@ def server_info_query(self, tvm_version):
                     optional=["build"],
                     type="bool",
                     help="Run make with verbose output",
-                )
+                ),
+                server.ProjectOption(
+                    "memory_size_bytes",
+                    optional=["generate_project"],
+                    type="int",
+                    default=None,

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org