You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/26 07:43:41 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4150: [ZEPPELIN-5425] Polish Interpreter class

zjffdu commented on a change in pull request #4150:
URL: https://github.com/apache/zeppelin/pull/4150#discussion_r659135001



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
##########
@@ -47,6 +51,35 @@ public InterpreterResult interpret(String st,
     return internalInterpret(st, context);
   }
 
+  static String interpolate(String cmd, ResourcePool resourcePool) {
+    Pattern zVariablePattern = Pattern.compile("([^{}]*)([{]+[^{}]*[}]+)(.*)", Pattern.DOTALL);

Review comment:
       Move it outside as static variable ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org