You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/04/25 21:25:54 UTC
Review Request 20724: Rename stacks resources stackServices,
serviceComponents and operatingSystems.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20724/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-5578
https://issues.apache.org/jira/browse/AMBARI-5578
Repository: ambari
Description
-------
Existing names are not consistent with the remaining api which uses an '_' instead of camel case.
Also these names are unnecessarily long. Since these names are not under the cluster resource, it is ok to reuse the names service and component for a more concise url.
So, the new stack api hierarchy would be:
stacks/versions/services/components/...
stacks/versions/operating_systems/...
Note This will not affect the stacks2 api that the UI uses.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 7c5eaf4
Diff: https://reviews.apache.org/r/20724/diff/
Testing
-------
Functional testing:
- created cluster via blueprint
- tested UI functionality
Unit tests:
Successfully ran unit tests
Results :
Tests run: 1570, Failures: 0, Errors: 0, Skipped: 9
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46.259s
[INFO] Finished at: Fri Apr 25 15:07:17 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel
Re: Review Request 20724: Rename stacks resources stackServices,
serviceComponents and operatingSystems.
Posted by John Speidel <js...@hortonworks.com>.
> On April 25, 2014, 7:32 p.m., Tom Beerbower wrote:
> > I guess we are counting on the fact that we haven't yet documented the new stacks API. Is there still a small chance that we break somebody using stacks?
Yep, since stacks was just added and hasn't been documented, we are assuming that it is not widely used. But as you state, we can't be certain.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20724/#review41511
-----------------------------------------------------------
On April 25, 2014, 7:25 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20724/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 7:25 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5578
> https://issues.apache.org/jira/browse/AMBARI-5578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing names are not consistent with the remaining api which uses an '_' instead of camel case.
> Also these names are unnecessarily long. Since these names are not under the cluster resource, it is ok to reuse the names service and component for a more concise url.
> So, the new stack api hierarchy would be:
> stacks/versions/services/components/...
> stacks/versions/operating_systems/...
>
> Note This will not affect the stacks2 api that the UI uses.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 7c5eaf4
>
> Diff: https://reviews.apache.org/r/20724/diff/
>
>
> Testing
> -------
>
> Functional testing:
> - created cluster via blueprint
> - tested UI functionality
>
> Unit tests:
> Successfully ran unit tests
>
> Results :
>
> Tests run: 1570, Failures: 0, Errors: 0, Skipped: 9
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46.259s
> [INFO] Finished at: Fri Apr 25 15:07:17 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 20724: Rename stacks resources stackServices,
serviceComponents and operatingSystems.
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20724/#review41511
-----------------------------------------------------------
Ship it!
I guess we are counting on the fact that we haven't yet documented the new stacks API. Is there still a small chance that we break somebody using stacks?
- Tom Beerbower
On April 25, 2014, 7:25 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20724/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 7:25 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5578
> https://issues.apache.org/jira/browse/AMBARI-5578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing names are not consistent with the remaining api which uses an '_' instead of camel case.
> Also these names are unnecessarily long. Since these names are not under the cluster resource, it is ok to reuse the names service and component for a more concise url.
> So, the new stack api hierarchy would be:
> stacks/versions/services/components/...
> stacks/versions/operating_systems/...
>
> Note This will not affect the stacks2 api that the UI uses.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 7c5eaf4
>
> Diff: https://reviews.apache.org/r/20724/diff/
>
>
> Testing
> -------
>
> Functional testing:
> - created cluster via blueprint
> - tested UI functionality
>
> Unit tests:
> Successfully ran unit tests
>
> Results :
>
> Tests run: 1570, Failures: 0, Errors: 0, Skipped: 9
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46.259s
> [INFO] Finished at: Fri Apr 25 15:07:17 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>