[jira] [Created] (SHINDIG-1744) Allow opensocial-data feature to be included as a dependency of other features

["Anthony Carlucci (Created) (JIRA)" <ji...@apache.org>]

Allow opensocial-data feature to be included as a dependency of other features
------------------------------------------------------------------------------

                 Key: SHINDIG-1744
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1744
             Project: Shindig
          Issue Type: Improvement
    Affects Versions: 3.0.0
            Reporter: Anthony Carlucci
            Priority: Minor


Including opensocial-data as a dependency in another feature doesn't properly include it when the gadget renders:

1) Create a new feature that includes opensocial-data as a dependency

<?xml version="1.0"?>
<feature>
    <name>my_super_feature</name>
    <dependency>opensocial-data</dependency>
    <gadget>
        <script src="my_super_feature.js"/>
    </gadget>
</feature>

2) Add the super feature to a gadget and use an opensocial-data tag:
...
<Require feature="my_super_feature"/>
...
...
<script type="text/os-data" xmlns:os="http://ns.opensocial.org/2008/markup">
    <os:OwnerRequest key="owner"/>
    <os:ViewerRequest key="viewer"/>
</script>
...
...

3) When the gadget renders, the text/os-data section is not parsed properly by shindig and is literally rendered in the gadget HTML

>From debugging I found the code of issue to be org.apache.shindig.gadgets.rewrite.PipelineDataGadgetRewriter#rewrite, line 61:
if (!gadget.getViewFeatures().containsKey("opensocial-data"))


A nice enhancement would be if this check could also parse through dependencies of the included features to search for opensocial-data.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira