You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/07 03:17:57 UTC

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15051: [fix] [broker] Fix ServerCnx.handleSubscribe add potentially duplicated consumer issue

HQebupt commented on code in PR #15051:
URL: https://github.com/apache/pulsar/pull/15051#discussion_r844598615


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2737,6 +2729,7 @@ public void cancelPublishBufferLimiting() {
             if (e.getCause() instanceof BrokerServiceException) {
                 error = BrokerServiceException.getClientErrorCode(e.getCause());
             }
+            log.error("some thing error.", e);

Review Comment:
   Please use more meaningful error log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org