You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2013/07/08 09:32:22 UTC
git commit: [CB-4090] Broken notification handling
Updated Branches:
refs/heads/2.9.x 770951b10 -> 183371d8d
[CB-4090] Broken notification handling
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/183371d8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/183371d8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/183371d8
Branch: refs/heads/2.9.x
Commit: 183371d8d3d609a5a265096248016cbb8b424ab8
Parents: 770951b
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Mon Jul 8 00:31:43 2013 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Mon Jul 8 00:31:43 2013 -0700
----------------------------------------------------------------------
common/Plugins/Notification.cs | 6 +++---
wp7/template/config.xml | 3 +++
wp8/template/config.xml | 3 +++
3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/183371d8/common/Plugins/Notification.cs
----------------------------------------------------------------------
diff --git a/common/Plugins/Notification.cs b/common/Plugins/Notification.cs
index 6d4b93b..7ff557c 100644
--- a/common/Plugins/Notification.cs
+++ b/common/Plugins/Notification.cs
@@ -106,7 +106,7 @@ namespace WPCordovaClassLib.Cordova.Commands
{
var previous = notifyBox;
notifyBox = new NotificationBox();
- notifyBox.Tag = new { previous = previous, callbackId = aliasCurrentCommandCallbackId };
+ notifyBox.Tag = new NotifBoxData { previous = previous, callbackId = aliasCurrentCommandCallbackId };
notifyBox.PageTitle.Text = alertOpts.title;
notifyBox.SubTitle.Text = alertOpts.message;
Button btnOK = new Button();
@@ -148,7 +148,7 @@ namespace WPCordovaClassLib.Cordova.Commands
{
var previous = notifyBox;
notifyBox = new NotificationBox();
- notifyBox.Tag = new { previous = previous, callbackId = aliasCurrentCommandCallbackId };
+ notifyBox.Tag = new NotifBoxData { previous = previous, callbackId = aliasCurrentCommandCallbackId };
notifyBox.PageTitle.Text = alertOpts.title;
notifyBox.SubTitle.Text = alertOpts.message;
@@ -242,7 +242,7 @@ namespace WPCordovaClassLib.Cordova.Commands
}
}
- DispatchCommandResult(new PluginResult(PluginResult.Status.OK, retVal),callbackId);
+ DispatchCommandResult(new PluginResult(PluginResult.Status.OK, retVal), callbackId);
}
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/183371d8/wp7/template/config.xml
----------------------------------------------------------------------
diff --git a/wp7/template/config.xml b/wp7/template/config.xml
index 6ef524c..c8d9cfc 100644
--- a/wp7/template/config.xml
+++ b/wp7/template/config.xml
@@ -79,6 +79,9 @@
<feature name="InAppBrowser">
<param name="wp-package" value="InAppBrowser"/>
</feature>
+ <feature name="Notification">
+ <param name="wp-package" value="Notification"/>
+ </feature>
</features>
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/183371d8/wp8/template/config.xml
----------------------------------------------------------------------
diff --git a/wp8/template/config.xml b/wp8/template/config.xml
index 6ef524c..c8d9cfc 100644
--- a/wp8/template/config.xml
+++ b/wp8/template/config.xml
@@ -79,6 +79,9 @@
<feature name="InAppBrowser">
<param name="wp-package" value="InAppBrowser"/>
</feature>
+ <feature name="Notification">
+ <param name="wp-package" value="Notification"/>
+ </feature>
</features>