You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/09/25 15:16:25 UTC

[jira] [Commented] (NIFI-604) ExecuteStreamCommand does not support arguments with semicolons

    [ https://issues.apache.org/jira/browse/NIFI-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908009#comment-14908009 ] 

ASF subversion and git services commented on NIFI-604:
------------------------------------------------------

Commit 9cefc4a5a54adf63bf4eb67c4b8211f2a2b5dd14 in nifi's branch refs/heads/master from [~rickysaltzer]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9cefc4a ]

NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess

- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments
- Argument delimiters can now be specified. Their default being what they were using before (; and space)


> ExecuteStreamCommand does not support arguments with semicolons 
> ----------------------------------------------------------------
>
>                 Key: NIFI-604
>                 URL: https://issues.apache.org/jira/browse/NIFI-604
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.1.0
>            Reporter: Ricky Saltzer
>            Assignee: Mark Payne
>             Fix For: 0.4.0
>
>         Attachments: NIFI-604.1.patch, NIFI-604.2.patch
>
>
> The following code in ExecuteStreamCommand assumes you're not passing semicolons within your argument. This is a problem for people who need to pass semicolons to the executing program as part of the argument. 
> {code}
> 224            for (String arg : commandArguments.split(";")) { 
> {code}
> To allow for escaped semicolons, I propose we change this to the following regex.
> {code}
> 224            for (String arg : commandArguments.split("[^\\];")) { 
> {code}
> *or*... could we just change the way arguments are passed to make it more similar to how ExecuteCommand works? The whole semicolon per argument took some getting used to, and doesn't seem very intuitive. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)