You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sebastian Davids (JIRA)" <ji...@codehaus.org> on 2011/12/07 11:37:40 UTC
[jira] Issue Comment Edited: (MWAR-164) Support for specifying
which encoding to use when filtering resources
[ https://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285110#comment-285110 ]
Sebastian Davids edited comment on MWAR-164 at 12/7/11 4:36 AM:
----------------------------------------------------------------
Please review patch and/or fix differently, thanks.
12 Votes and patch exists for almost a year now ...
I am in favor of being consistent with the resources plugin: http://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html#encoding
http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding
was (Author: sdavids):
Please review patch and/or fix differently, thanks.
12 Votes and patch exists for almost a year now ...
I am in favor of being consistent with the resources plugin: http://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html#encoding
> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
> Key: MWAR-164
> URL: https://jira.codehaus.org/browse/MWAR-164
> Project: Maven 2.x WAR Plugin
> Issue Type: Improvement
> Components: filtering
> Affects Versions: 2.1-alpha-1
> Reporter: kai lilleby
> Fix For: 2.2
>
> Attachments: MWAR-164-maven-war-plugin.patch
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira