You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/08 04:07:15 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7193: function to read compacted topics

codelipenghui commented on a change in pull request #7193:
URL: https://github.com/apache/pulsar/pull/7193#discussion_r436447865



##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -276,6 +277,9 @@ protected void validateSinkConfigs(SinkConfig sinkConfig) {
         @Parameter(names = "--custom-schema-inputs", description = "The map of input topics to Schema types or class names (as a JSON string)")
         protected String customSchemaInputString;
 
+        @Parameter(names = "--input-specs", description = "The map of inputs to custom configuration (as a JSON string)")

Review comment:
       Is this related to this PR?

##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -233,6 +234,8 @@ void processArguments() throws Exception {
         protected String customSerdeInputString;
         @Parameter(names = "--custom-schema-inputs", description = "The map of input topics to Schema class names (as a JSON string)")
         protected String customSchemaInputString;
+        @Parameter(names = "--input-specs", description = "The map of inputs to custom configuration (as a JSON string)")

Review comment:
       Is this related to this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org