[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3294: ARTEMIS-2937 Server Side AMQP Connectivity with options to transfer queue or replicate data

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #3294:
URL: https://github.com/apache/activemq-artemis/pull/3294#discussion_r504718593



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPRemoteControlsSource.java
##########
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.protocol.amqp.connect;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.api.core.QueueConfiguration;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.server.ActiveMQComponent;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.MessageReference;
+import org.apache.activemq.artemis.core.server.Queue;
+import org.apache.activemq.artemis.core.server.RoutingContext;
+import org.apache.activemq.artemis.core.server.impl.AckReason;
+import org.apache.activemq.artemis.core.server.impl.AddressInfo;
+import org.apache.activemq.artemis.core.server.impl.RoutingContextImpl;
+import org.apache.activemq.artemis.core.server.remotecontrol.RemoteControl;
+import org.apache.activemq.artemis.core.transaction.Transaction;
+import org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage;
+import org.apache.activemq.artemis.protocol.amqp.broker.AMQPStandardMessage;
+import org.apache.activemq.artemis.protocol.amqp.util.NettyWritable;
+import org.apache.activemq.artemis.protocol.amqp.util.TLSEncode;
+import org.apache.qpid.proton.amqp.Symbol;
+import org.apache.qpid.proton.amqp.messaging.AmqpValue;
+import org.apache.qpid.proton.amqp.messaging.DeliveryAnnotations;
+import org.apache.qpid.proton.amqp.messaging.Header;
+import org.apache.qpid.proton.amqp.messaging.MessageAnnotations;
+import org.apache.qpid.proton.amqp.messaging.Properties;
+import org.apache.qpid.proton.amqp.messaging.Section;
+import org.apache.qpid.proton.codec.EncoderImpl;
+import org.apache.qpid.proton.codec.WritableBuffer;
+import org.jboss.logging.Logger;
+
+public class AMQPRemoteControlsSource implements RemoteControl, ActiveMQComponent {
+
+   private static final Logger logger = Logger.getLogger(AMQPRemoteControlsSource.class);
+
+   public static final Symbol EVENT_TYPE = Symbol.getSymbol("ma.EVENT_TYPE");
+   public static final Symbol ADDRESS = Symbol.getSymbol("ma.ADDRESS");
+   public static final Symbol QUEUE = Symbol.getSymbol("ma.QUEUE");
+
+   // Events:
+   public static final Symbol ADD_ADDRESS = Symbol.getSymbol("addAddress");
+   public static final Symbol DELETE_ADDRESS = Symbol.getSymbol("deleteAddress");
+   public static final Symbol CREATE_QUEUE = Symbol.getSymbol("createQueue");
+   public static final Symbol DELETE_QUEUE = Symbol.getSymbol("deleteQueue");
+   public static final Symbol ADDRESS_SCAN_START = Symbol.getSymbol("AddressCanStart");
+   public static final Symbol ADDRESS_SCAN_END = Symbol.getSymbol("AddressScanEnd");
+   public static final Symbol POST_ACK = Symbol.getSymbol("postAck");
+
+   // Delivery annotation property used on remote control routing and Ack
+   public static final Symbol INTERNAL_ID = Symbol.getSymbol("ma.INTERNAL_ID");
+
+   private static final ThreadLocal<RemoteControlRouting> remoteControlRouting = ThreadLocal.withInitial(() -> new RemoteControlRouting(null));
+
+   final Queue snfQueue;
+   final ActiveMQServer server;
+   final boolean acks;
+
+   boolean started;
+
+   @Override
+   public void start() throws Exception {
+   }
+
+   @Override
+   public void stop() throws Exception {
+   }
+
+   @Override
+   public boolean isStarted() {
+      return started;
+   }
+
+   public AMQPRemoteControlsSource(Queue snfQueue, ActiveMQServer server, boolean acks) {
+      this.snfQueue = snfQueue;
+      this.server = server;
+      this.acks = acks;
+   }
+
+   @Override
+   public void startAddressScan() throws Exception {
+      Message message = createMessage(null, null, ADDRESS_SCAN_START, null);
+      route(server, message);
+   }
+
+   @Override
+   public void endAddressScan() throws Exception {
+      Message message = createMessage(null, null, ADDRESS_SCAN_END, null);
+      route(server, message);
+   }
+
+   @Override
+   public void addAddress(AddressInfo addressInfo) throws Exception {
+      Message message = createMessage(addressInfo.getName(), null, ADD_ADDRESS, addressInfo.toJSON());
+      route(server, message);
+   }
+
+   @Override
+   public void deleteAddress(AddressInfo addressInfo) throws Exception {
+      Message message = createMessage(addressInfo.getName(), null, DELETE_ADDRESS, addressInfo.toJSON());
+      route(server, message);
+   }
+
+   @Override
+   public void createQueue(QueueConfiguration queueConfiguration) throws Exception {
+      Message message = createMessage(queueConfiguration.getAddress(), queueConfiguration.getName(), CREATE_QUEUE, queueConfiguration.toJSON());
+      route(server, message);
+   }
+
+   @Override
+   public void deleteQueue(SimpleString address, SimpleString queue) throws Exception {
+      Message message = createMessage(address, queue, DELETE_QUEUE, queue.toString());
+      route(server, message);
+   }
+
+   @Override
+   public void sendMessage(Message message, RoutingContext context, List<MessageReference> refs) {
+
+      try {
+         context.setReusable(false);
+         MessageReference ref = MessageReference.Factory.createReference(message, snfQueue);
+
+         Map<Symbol, Object> symbolObjectMap = new HashMap<>();
+         DeliveryAnnotations deliveryAnnotations = new DeliveryAnnotations(symbolObjectMap);
+         symbolObjectMap.put(INTERNAL_ID, message.getMessageID());
+         ref.setProtocolData(deliveryAnnotations);
+
+         refs.add(ref);
+         message.usageUp();
+      } catch (Throwable e) {
+         logger.warn(e.getMessage(), e);
+      }
+   }
+
+   @Override
+   public void postAcknowledge(MessageReference ref, AckReason reason) throws Exception {
+      if (acks && !ref.getQueue().isRemoteControl()) { // we don't call postACK on snfqueues, otherwise we would get infinite loop because of this feedback
+         Message message = createMessage(ref.getQueue().getAddress(), ref.getQueue().getName(), POST_ACK, ref.getMessage().getMessageID());
+         route(server, message);
+         ref.getMessage().usageDown();
+      }
+   }
+
+   private Message createMessage(SimpleString address, SimpleString queue, Object event, Object body) {
+      return createMessage(snfQueue.getAddress().toString(), address, queue, event, body);
+   }
+
+   /** This method is open to make it testable,
+    * do not use on your applications. */
+   public static Message createMessage(String to, SimpleString address, SimpleString queue, Object event, Object body) {
+      Header header = new Header();
+      header.setDurable(true);
+
+      Map<Symbol, Object> annotations = new HashMap<>();
+      annotations.put(EVENT_TYPE, event);
+      if (address != null) {
+         annotations.put(ADDRESS, address.toString());
+      }
+      if (queue != null) {
+         annotations.put(QUEUE, queue.toString());
+      }
+      MessageAnnotations messageAnnotations = new MessageAnnotations(annotations);
+
+      Properties properties = new Properties();
+      properties.setTo(to);
+
+      Section sectionBody = body != null ? new AmqpValue(body) : null;
+
+      ByteBuf buffer = PooledByteBufAllocator.DEFAULT.heapBuffer(1024);
+
+      try {
+         EncoderImpl encoder = TLSEncode.getEncoder();
+         encoder.setByteBuffer(new NettyWritable(buffer));
+         encoder.writeObject(header);
+         encoder.writeObject(messageAnnotations);
+         encoder.writeObject(properties);
+         if (sectionBody != null) {
+            encoder.writeObject(sectionBody);
+         }
+
+         byte[] data = new byte[buffer.writerIndex()];
+         buffer.readBytes(data);
+
+         AMQPMessage amqpMessage = new AMQPStandardMessage(0, data, null);
+         return amqpMessage;
+
+      } finally {
+         TLSEncode.getEncoder().setByteBuffer((WritableBuffer) null);
+         buffer.release();
+      }
+   }
+
+   public static void route(ActiveMQServer server, Message message) throws Exception {
+      message.setMessageID(server.getStorageManager().generateID());
+      RemoteControlRouting ctx = remoteControlRouting.get();
+      ctx.clear();
+      server.getPostOffice().route(message, ctx, false);
+   }
+
+   @Override
+   public void routingDone(List<MessageReference> refs, boolean direct) {
+      /*for (MessageReference ref : refs) {

Review comment:
       commented code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org