[kudu] 02/05: util: quell warning in sockaddr.cc

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 54b9a5987ef649806f830a4d1276902d145ab162
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Tue May 12 18:40:55 2020 -0700

    util: quell warning in sockaddr.cc
    
    Building in DEBUG mode, I would see the following warning.
    
    [397/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/net/sockaddr.cc.o
    ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’:
    ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type]
     }
     ^
    [509/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util_exported.dir/net/sockaddr.cc.o
    ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’:
    ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type]
     }
     ^
    
    Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7
    Reviewed-on: http://gerrit.cloudera.org:8080/15908
    Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
    Tested-by: Andrew Wong <aw...@cloudera.com>
---
 src/kudu/util/net/sockaddr.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/kudu/util/net/sockaddr.cc b/src/kudu/util/net/sockaddr.cc
index f5d616c..7653617 100644
--- a/src/kudu/util/net/sockaddr.cc
+++ b/src/kudu/util/net/sockaddr.cc
@@ -149,6 +149,8 @@ string Sockaddr::UnixDomainPath() const {
       size_t len = len_ - offsetof(struct sockaddr_un, sun_path) - 1;
       return "@" + string(storage_.un.sun_path + 1, len);
   }
+  LOG(FATAL) << "unknown unix address type";
+  return "";
 }
 
 Sockaddr::UnixAddressType Sockaddr::unix_address_type() const {