You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/01/11 11:20:22 UTC

[GitHub] [zeppelin] yejingchen commented on a change in pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

yejingchen commented on a change in pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#discussion_r554978114



##########
File path: bin/common.sh
##########
@@ -66,6 +66,7 @@ fi
 ZEPPELIN_CLASSPATH+=":${ZEPPELIN_CONF_DIR}"
 
 function check_java_version() {
+    [[ ${JAVA_HOME+x} ]] && JAVA="$JAVA_HOME/bin/java"

Review comment:
       Changed to if statement.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org