You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/08 22:41:56 UTC
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5011
to review the following change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Allow binaries built on el6.6+ to run on el6.4
This provides a workaround to an OpenSSL ABI compatibility break between
el6.4 and later versions.
See the comment in install-openssl-el6-workaround.sh for details.
Change-Id: I115540d59580170404f9e65303214edf95b592e6
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/install-openssl-el6-workaround.sh
M thirdparty/vars.sh
4 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5011/1
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
PS1, Line 259: CentOS|Red Hat Enterprise
> good question. Do you happen to know of an OEL system I can ssh into and po
I don't have one, no. Given that we don't explicitly advertise OEL support, leaving it as-is is fine with me.
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 173: OPENSSL_WORKAROUND_DIR="$TP_DIR/installed/openssl-el6-workaround"
> I figured since it's a "weird" install (i.e it has a whole /usr directory i
Makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
PS1, Line 259: CentOS|Red Hat Enterprise
> What about Oracle Enterprise Linux? Isn't its userspace binary compatible w
good question. Do you happen to know of an OEL system I can ssh into and poke around? If not, I'd rather leave as is until someone is building on that system and runs into this issue.
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 173: OPENSSL_WORKAROUND_DIR="$TP_DIR/installed/openssl-el6-workaround"
> Why not installed/uninstrumented/... ?
I figured since it's a "weird" install (i.e it has a whole /usr directory inside it) it doesn't make sense to overlay on top of the normal "install" directory.
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
PS1, Line 259: CentOS|Red Hat Enterprise
What about Oracle Enterprise Linux? Isn't its userspace binary compatible with RHEL?
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/install-openssl-el6-workaround.sh
File thirdparty/install-openssl-el6-workaround.sh:
PS1, Line 39: RhEL
RHEL
http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 173: OPENSSL_WORKAROUND_DIR="$TP_DIR/installed/openssl-el6-workaround"
Why not installed/uninstrumented/... ?
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5011
to look at the new patch set (#2).
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Allow binaries built on el6.6+ to run on el6.4
This provides a workaround to an OpenSSL ABI compatibility break between
el6.4 and later versions.
See the comment in install-openssl-el6-workaround.sh for details.
Change-Id: I115540d59580170404f9e65303214edf95b592e6
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/install-openssl-el6-workaround.sh
M thirdparty/vars.sh
4 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5011/2
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Allow binaries built on el6.6+ to run on el6.4
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Allow binaries built on el6.6+ to run on el6.4
......................................................................
Allow binaries built on el6.6+ to run on el6.4
This provides a workaround to an OpenSSL ABI compatibility break between
el6.4 and later versions.
See the comment in install-openssl-el6-workaround.sh for details.
Change-Id: I115540d59580170404f9e65303214edf95b592e6
Reviewed-on: http://gerrit.cloudera.org:8080/5011
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/install-openssl-el6-workaround.sh
M thirdparty/vars.sh
4 files changed, 101 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I115540d59580170404f9e65303214edf95b592e6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>