You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/06 07:26:11 UTC

[GitHub] [pulsar] wangjialing218 opened a new pull request #9136: fix the closed ledger did not delete after expired

wangjialing218 opened a new pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136


   ### Motivation
   Fixes #9057
   
   When current ledger closed, if there is no incoming traffic, the read position of the cursor is still point to the last entry of the closed ledger,  that casue the `slowestReaderLedgerId` point to the closed ledger in `internalTrimConsumedLedgers()` and fail to delete the closed ledger.
   
   ### Modifications
   When close current ledger, if cursor's read position point to the last entry of current ledger, move the position to the new created ledger. 
   
   ### Verifying this change
   add test case: testDeletionAfterLedgerClosedAndRetention()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-756611356


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-755818097


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-755952366


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-756611356


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-756483521


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9136: fix the closed ledger did not delete after expired

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9136:
URL: https://github.com/apache/pulsar/pull/9136#issuecomment-755950064


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org