You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dayknightmare (via GitHub)" <gi...@apache.org> on 2023/04/03 17:31:54 UTC

[GitHub] [superset] dayknightmare opened a new pull request, #23565: fix: Add default empty array to filter dependencies

dayknightmare opened a new pull request, #23565:
URL: https://github.com/apache/superset/pull/23565

   fix(filters): Add default empty array to filter 
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Add default empty array to filter when ```formFilter?.dependencies``` and  ```filterToEdit?.cascadeParentIds``` is null or undefined
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   ![Captura de Tela 2023-04-03 às 14 25 32](https://user-images.githubusercontent.com/36389095/229582932-c087aa6a-c875-40ea-8912-29d0b65f1b26.png)
   
   After:
   ![Captura de Tela 2023-04-03 às 14 31 20](https://user-images.githubusercontent.com/36389095/229584137-ab044401-221f-467f-b763-aee5c2d57bbf.png)
   
   ### TESTING INSTRUCTIONS
   
   1. Go to 'dashboards'
   2. Click on '+ dashboard'
   3. Create any chart and add to dashboard
   4. Create a time range filter for the dashboard
   5. Save filters change
   6. Back to add edit filters
   7. Try to create new filter
   8. See solution
   
   ### ADDITIONAL INFORMATION
   - [X] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Fixes #23564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro merged pull request #23565: fix: Add default empty array to filter dependencies

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23565:
URL: https://github.com/apache/superset/pull/23565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on pull request #23565: fix: Add default empty array to filter dependencies

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23565:
URL: https://github.com/apache/superset/pull/23565#issuecomment-1579587054

   Also related: https://github.com/apache/superset/pull/23682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] paulocod commented on pull request #23565: fix: Add default empty array to filter dependencies

Posted by "paulocod (via GitHub)" <gi...@apache.org>.
paulocod commented on PR #23565:
URL: https://github.com/apache/superset/pull/23565#issuecomment-1494715722

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #23565: fix: Add default empty array to filter dependencies

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23565:
URL: https://github.com/apache/superset/pull/23565#issuecomment-1494887799

   ## [Codecov](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23565](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b96d8f) into [master](https://codecov.io/gh/apache/superset/commit/13ffb4b7c203cfa8ebec602fc7c25103eebc019f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13ffb4b) will **increase** coverage by `0.00%`.
   > The diff coverage is `86.84%`.
   
   > :exclamation: Current head 1b96d8f differs from pull request most recent head f74281d. Consider uploading reports for the commit f74281d to get more accurate results
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #23565   +/-   ##
   =======================================
     Coverage   67.70%   67.71%           
   =======================================
     Files        1914     1914           
     Lines       73961    73994   +33     
     Branches     8029     8033    +4     
   =======================================
   + Hits        50076    50102   +26     
   - Misses      21838    21842    +4     
   - Partials     2047     2050    +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.93% <83.33%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `85.71% <ø> (ø)` | |
   | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `80.00% <66.66%> (+2.22%)` | :arrow_up: |
   | [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `86.79% <80.00%> (+1.28%)` | :arrow_up: |
   | [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `74.40% <87.50%> (ø)` | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `38.65% <88.88%> (+0.48%)` | :arrow_up: |
   | [superset/charts/filters.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `88.40% <90.00%> (+0.07%)` | :arrow_up: |
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `55.17% <100.00%> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/23565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.58% <100.00%> (+0.03%)` | :arrow_up: |
   
   ... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23565/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org