You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Binyao Jiang (Jira)" <ji...@apache.org> on 2020/08/05 18:50:00 UTC

[jira] [Updated] (SAMZA-2569) Add features into StreamAppender

     [ https://issues.apache.org/jira/browse/SAMZA-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Binyao Jiang updated SAMZA-2569:
--------------------------------
    Description: 
Feature:
 # Make StreamAppender extend-friendly. 
 # Add metrics reporter into StreamAppender to report collected local metrics.
 # Add log message count, bytes and errors metrics in StreamAppender

Changes:
 # Rewrite StreamAppender to expose private members/functions as protected and split some heavy functions into small trunks.
 # Add metrics reporter to report the metrics we collect locally
 # Add those new metrics into StreamAppender

Tests:
 # Unit tests pass for updated StreamAppender
 # {{./gradlew build.}}

API Changes: new metrics will be introduced in StreamAppender and will get reported if metrics reporter is set. This applies to application that uses StreamAppender in log4j2.xml

Upgrade/usage instructions:

1. If users write new appender or extends existing StreamAppender for own use cases, feel free to update their appender code to extend new StreamAppender to make code neater.

2. If users want to report these collected metrics through metrics reporter, add metrics reporter related configs (See MetricsConfig.java for more details)

  was:
Feature:
 # Make StreamAppender extend-friendly. 
 # Add metrics reporter into StreamAppender to report collected local metrics.
 # Add log message count and bytes metrics in StreamAppender

Changes:
 # Rewrite StreamAppender to expose private members/functions as protected and split some heavy functions into small trunks.
 # Add metrics reporter to report the metrics we collect locally
 # Add those new metrics into StreamAppender

Tests:
 # Unit tests pass for updated StreamAppender
 # {{./gradlew build.}}

API Changes: two new metrics will be introduced in StreamAppender and will get reported if metrics reporter is set. This applies to application that uses StreamAppender in log4j2.xml

Upgrade/usage instructions:

1. If users write new appender or extends existing StreamAppender for own use cases, feel free to update their appender code to extend new StreamAppender to make code neater.

2. If users want to report these collected metrics through metrics reporter, add metrics reporter related configs (See MetricsConfig.java for more details)


> Add features into StreamAppender
> --------------------------------
>
>                 Key: SAMZA-2569
>                 URL: https://issues.apache.org/jira/browse/SAMZA-2569
>             Project: Samza
>          Issue Type: New Feature
>            Reporter: Binyao Jiang
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Feature:
>  # Make StreamAppender extend-friendly. 
>  # Add metrics reporter into StreamAppender to report collected local metrics.
>  # Add log message count, bytes and errors metrics in StreamAppender
> Changes:
>  # Rewrite StreamAppender to expose private members/functions as protected and split some heavy functions into small trunks.
>  # Add metrics reporter to report the metrics we collect locally
>  # Add those new metrics into StreamAppender
> Tests:
>  # Unit tests pass for updated StreamAppender
>  # {{./gradlew build.}}
> API Changes: new metrics will be introduced in StreamAppender and will get reported if metrics reporter is set. This applies to application that uses StreamAppender in log4j2.xml
> Upgrade/usage instructions:
> 1. If users write new appender or extends existing StreamAppender for own use cases, feel free to update their appender code to extend new StreamAppender to make code neater.
> 2. If users want to report these collected metrics through metrics reporter, add metrics reporter related configs (See MetricsConfig.java for more details)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)