You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/08/26 05:50:18 UTC
Review Request 72805: Added a test helper for CSI volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/
-----------------------------------------------------------
Review request for mesos and Qian Zhang.
Repository: mesos
Description
-------
Added a test helper for CSI volumes.
Diffs
-----
src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1
Diff: https://reviews.apache.org/r/72805/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 72805: Added a test helper for CSI volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 26, 2020, 6:57 a.m., Qian Zhang wrote:
> > src/tests/mesos.hpp
> > Lines 2097 (patched)
> > <https://reviews.apache.org/r/72805/diff/1/?file=2238772#file2238772line2097>
> >
> > Do we need another `createVolumeHostPath` in the `internal` namespace at line 1804?
We could add it if we want one for the v0 message type. I didn't add it here because I don't need it yet. Do you think I should add it now?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/#review221713
-----------------------------------------------------------
On Aug. 26, 2020, 5:50 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72805/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 5:50 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test helper for CSI volumes.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1
>
>
> Diff: https://reviews.apache.org/r/72805/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72805: Added a test helper for CSI volumes.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/#review221713
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mesos.hpp
Lines 873-874 (patched)
<https://reviews.apache.org/r/72805/#comment310764>
A newline between.
src/tests/mesos.hpp
Lines 2097 (patched)
<https://reviews.apache.org/r/72805/#comment310765>
Do we need another `createVolumeHostPath` in the `internal` namespace at line 1804?
- Qian Zhang
On Aug. 26, 2020, 1:50 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72805/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 1:50 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test helper for CSI volumes.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1
>
>
> Diff: https://reviews.apache.org/r/72805/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72805: Added a test helper for CSI volumes.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/#review221775
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 2, 2020, 1:50 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72805/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2020, 1:50 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test helper for CSI volumes.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1
>
>
> Diff: https://reviews.apache.org/r/72805/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72805: Added a test helper for CSI volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/
-----------------------------------------------------------
(Updated Sept. 2, 2020, 5:50 a.m.)
Review request for mesos and Qian Zhang.
Repository: mesos
Description
-------
Added a test helper for CSI volumes.
Diffs (updated)
-----
src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1
Diff: https://reviews.apache.org/r/72805/diff/2/
Changes: https://reviews.apache.org/r/72805/diff/1-2/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann