You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2016/04/05 15:04:50 UTC
svn commit: r1737835 - in
/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb:
./ logging/ replication/
Author: orudyy
Date: Tue Apr 5 13:04:49 2016
New Revision: 1737835
URL: http://svn.apache.org/viewvc?rev=1737835&view=rev
Log:
QPID-7023: [Java Broker] Change severety of cleaner warning logs about not deleted protected files to DEBUG if number of protected files is less than 10
Modified:
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBUtils.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/EnvironmentFacade.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentConfiguration.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacade.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacadeFactory.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/logging/Slf4jLoggingHandler.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentConfiguration.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java
qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeFactory.java
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBUtils.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBUtils.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBUtils.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBUtils.java Tue Apr 5 13:04:49 2016
@@ -174,4 +174,19 @@ public class BDBUtils
}
return EnvironmentFacade.CACHE_MODE_DEFAULT;
}
+
+ public static <T> T getContextValue(final ConfiguredObject<?> parent,
+ Class<T> paremeterClass,
+ final String parameterName,
+ final T defaultValue)
+ {
+ if (parent.getContextKeys(false).contains(parameterName))
+ {
+ return parent.getContextValue(paremeterClass, parameterName);
+ }
+ else
+ {
+ return defaultValue;
+ }
+ }
}
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/EnvironmentFacade.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/EnvironmentFacade.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/EnvironmentFacade.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/EnvironmentFacade.java Tue Apr 5 13:04:49 2016
@@ -55,6 +55,9 @@ public interface EnvironmentFacade
String CACHE_MODE_PROPERTY_NAME = "qpid.bdb.cache_mode";
CacheMode CACHE_MODE_DEFAULT = CacheMode.EVICT_LN;
+ String LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT_PROPERTY_NAME = "qpid.bdb.je.cleaner_protected_files_limit";
+ int DEFAULT_LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT = 10;
+
void upgradeIfNecessary(ConfiguredObject<?> parent);
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentConfiguration.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentConfiguration.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentConfiguration.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentConfiguration.java Tue Apr 5 13:04:49 2016
@@ -29,4 +29,6 @@ public interface StandardEnvironmentConf
String getStorePath();
CacheMode getCacheMode();
Map<String, String> getParameters();
+
+ int getFacadeParameter(String parameterName, int defaultValue);
}
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacade.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacade.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacade.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacade.java Tue Apr 5 13:04:49 2016
@@ -32,7 +32,6 @@ import java.util.concurrent.ConcurrentMa
import java.util.concurrent.atomic.AtomicReference;
import com.google.common.util.concurrent.ListenableFuture;
-import com.sleepycat.je.CacheMode;
import com.sleepycat.je.CheckpointConfig;
import com.sleepycat.je.Database;
import com.sleepycat.je.DatabaseConfig;
@@ -109,7 +108,10 @@ public class StandardEnvironmentFacade i
envConfig.setAllowCreate(true);
envConfig.setTransactional(true);
envConfig.setCacheMode(configuration.getCacheMode());
- envConfig.setLoggingHandler(new Slf4jLoggingHandler("["+configuration.getName()+"]"));
+ int logHandlerCleanerProtectedFilesLimit = configuration.getFacadeParameter(LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT_PROPERTY_NAME,
+ DEFAULT_LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT);
+ envConfig.setLoggingHandler(new Slf4jLoggingHandler("[" + configuration.getName() + "]",
+ logHandlerCleanerProtectedFilesLimit));
LOGGER.debug("Cache mode {}", envConfig.getCacheMode());
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacadeFactory.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacadeFactory.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacadeFactory.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/StandardEnvironmentFacadeFactory.java Tue Apr 5 13:04:49 2016
@@ -71,6 +71,12 @@ public class StandardEnvironmentFacadeFa
{
return BDBUtils.getEnvironmentConfigurationParameters(parent);
}
+
+ @Override
+ public int getFacadeParameter(final String parameterName, final int defaultValue)
+ {
+ return BDBUtils.getContextValue(parent, Integer.class, parameterName, defaultValue);
+ }
};
return new StandardEnvironmentFacade(sec);
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/logging/Slf4jLoggingHandler.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/logging/Slf4jLoggingHandler.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/logging/Slf4jLoggingHandler.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/logging/Slf4jLoggingHandler.java Tue Apr 5 13:04:49 2016
@@ -30,6 +30,8 @@ import java.util.logging.Formatter;
import java.util.logging.Handler;
import java.util.logging.Level;
import java.util.logging.LogRecord;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
import com.sleepycat.je.cleaner.Cleaner;
import org.slf4j.Logger;
@@ -38,9 +40,12 @@ import org.slf4j.LoggerFactory;
public class Slf4jLoggingHandler extends Handler
{
+ private static Pattern NOT_DELETED_DUE_TO_PROTECTION = Pattern.compile("Cleaner has ([0-9]+) files not deleted because they are protected.*");
+
private final ConcurrentMap<String,Logger> _loggers = new ConcurrentHashMap<>();
+ private final int _logHandlerCleanerProtectedFilesLimit;
- public Slf4jLoggingHandler(final String prefix)
+ public Slf4jLoggingHandler(final String prefix, final int logHandlerCleanerProtectedFilesLimit)
{
setFormatter(new Formatter()
{
@@ -50,6 +55,7 @@ public class Slf4jLoggingHandler extends
return prefix + " " + formatMessage(record);
}
});
+ _logHandlerCleanerProtectedFilesLimit = logHandlerCleanerProtectedFilesLimit;
}
private interface MappedLevel
@@ -193,14 +199,30 @@ public class Slf4jLoggingHandler extends
private MappedLevel convertLevel(LogRecord record)
{
- if (record.getLevel() == Level.SEVERE && record.getLoggerName().equals(Cleaner.class.getName()) && record.getMessage().startsWith("Average cleaner backlog has grown from"))
+ if (record.getLevel() == Level.SEVERE && isJECleaner(record)
+ && record.getMessage().startsWith("Average cleaner backlog has grown from"))
{
// this is not a real ERROR condition; reducing level to INFO
return INFO;
}
+
+ if (record.getLevel() == Level.WARNING && isJECleaner(record))
+ {
+ Matcher matcher = NOT_DELETED_DUE_TO_PROTECTION.matcher(record.getMessage());
+ if (matcher.matches() && matcher.groupCount() > 0 && Integer.parseInt(matcher.group(1)) < _logHandlerCleanerProtectedFilesLimit)
+ {
+ return DEBUG;
+ }
+ }
+
return convertLevel(record.getLevel());
}
+ private boolean isJECleaner(final LogRecord record)
+ {
+ return Cleaner.class.getName().equals(record.getLoggerName());
+ }
+
@Override
public boolean isLoggable(final LogRecord record)
{
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentConfiguration.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentConfiguration.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentConfiguration.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentConfiguration.java Tue Apr 5 13:04:49 2016
@@ -35,5 +35,4 @@ public interface ReplicatedEnvironmentCo
int getQuorumOverride();
Map<String, String> getReplicationParameters();
String getHelperNodeName();
- int getFacadeParameter(String parameterName, int defaultValue);
}
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java Tue Apr 5 13:04:49 2016
@@ -130,6 +130,8 @@ public class ReplicatedEnvironmentFacade
*/
private final int _executorShutdownTimeout;
+ private final int _logHandlerCleanerProtectedFilesLimit;
+
static final SyncPolicy LOCAL_TRANSACTION_SYNCHRONIZATION_POLICY = SyncPolicy.SYNC;
static final SyncPolicy REMOTE_TRANSACTION_SYNCHRONIZATION_POLICY = SyncPolicy.NO_SYNC;
public static final ReplicaAckPolicy REPLICA_REPLICA_ACKNOWLEDGMENT_POLICY = ReplicaAckPolicy.SIMPLE_MAJORITY;
@@ -259,6 +261,8 @@ public class ReplicatedEnvironmentFacade
_remoteNodeMonitorTimeout = configuration.getFacadeParameter(REMOTE_NODE_MONITOR_TIMEOUT_PROPERTY_NAME, DEFAULT_REMOTE_NODE_MONITOR_TIMEOUT);
_environmentRestartRetryLimit = configuration.getFacadeParameter(ENVIRONMENT_RESTART_RETRY_LIMIT_PROPERTY_NAME, DEFAULT_ENVIRONMENT_RESTART_RETRY_LIMIT);
_executorShutdownTimeout = configuration.getFacadeParameter(EXECUTOR_SHUTDOWN_TIMEOUT_PROPERTY_NAME, DEFAULT_EXECUTOR_SHUTDOWN_TIMEOUT);
+ _logHandlerCleanerProtectedFilesLimit = _configuration.getFacadeParameter(LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT_PROPERTY_NAME,
+ DEFAULT_LOG_HANDLER_CLEANER_PROTECTED_FILES_LIMIT);
_defaultDurability = new Durability(LOCAL_TRANSACTION_SYNCHRONIZATION_POLICY, REMOTE_TRANSACTION_SYNCHRONIZATION_POLICY, REPLICA_REPLICA_ACKNOWLEDGMENT_POLICY);
_prettyGroupNodeName = _configuration.getGroupName() + ":" + _configuration.getName();
@@ -1566,7 +1570,9 @@ public class ReplicatedEnvironmentFacade
envConfig.setExceptionListener(new ExceptionListener());
envConfig.setDurability(_defaultDurability);
envConfig.setCacheMode(_configuration.getCacheMode());
- envConfig.setLoggingHandler(new Slf4jLoggingHandler("[" + _configuration.getName() + "]"));
+
+
+ envConfig.setLoggingHandler(new Slf4jLoggingHandler("[" + _configuration.getName() + "]", _logHandlerCleanerProtectedFilesLimit));
LOGGER.info("Cache mode {}", envConfig.getCacheMode());
Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeFactory.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeFactory.java?rev=1737835&r1=1737834&r2=1737835&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeFactory.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeFactory.java Tue Apr 5 13:04:49 2016
@@ -114,14 +114,7 @@ public class ReplicatedEnvironmentFacade
@Override
public int getFacadeParameter(final String parameterName, final int defaultValue)
{
- if (parent.getContextKeys(false).contains(parameterName))
- {
- return parent.getContextValue(Integer.class, parameterName);
- }
- else
- {
- return defaultValue;
- }
+ return BDBUtils.getContextValue(parent, Integer.class, parameterName, defaultValue);
}
};
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org