You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/23 01:07:09 UTC
[GitHub] [kafka] guozhangwang opened a new pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks
guozhangwang opened a new pull request #11112:
URL: https://github.com/apache/kafka/pull/11112
Since now we call do not necessarily complete the rebalance within a poll call, we may keep checking the `rejoinNeededOrPending` which hits either of the conditions and returns true, but then returns early, resulting in flooding log entries. This PR would only log/set the flag when it was not set yet, effectively only logging for the first time.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11112:
URL: https://github.com/apache/kafka/pull/11112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11112:
URL: https://github.com/apache/kafka/pull/11112#issuecomment-885335038
@ableegoldman please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11112:
URL: https://github.com/apache/kafka/pull/11112#issuecomment-885414377
Test failures are known. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11112:
URL: https://github.com/apache/kafka/pull/11112#issuecomment-885414788
Would not merge to 3.0 since it is not a blocker and we've past code freeze deadline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org