You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/09/30 09:09:04 UTC
[GitHub] zeppelin pull request #1476: [WIP] ZEPPELIN-335. Pig Interpreter
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1476
[WIP] ZEPPELIN-335. Pig Interpreter
### What is this PR for?
Based on #338 , I refactor most of pig interpreter. As I don't think the approach in #338 is the best approach. In #338, we use script `bin/pig` to launch pig script, it is different to control that job (hard to kill and get progress and stats info). In this PR, I use pig api to launch pig script. Besides that I implement another interpreter type `%pig.query` to leverage the display system of zeppelin. For the details you can check `pig.md`
### What type of PR is it?
[Feature]
### Todos
* Syntax Highlight
* new interpreter type `%pig.udf`, so that user can write pig udf in zeppelin directly and don't need to build udf jar manually.
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-335
### How should this be tested?
Unit test is added and also manual test is done
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1476
----
commit ef2223abab92a452b48372ac0b4c50b70646f984
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T05:40:06Z
initial commit of pig interpreter
commit 656329d00a766570b25970506aa9e7a95edd8f8a
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T06:25:47Z
exposed timeout and pig executable via interpreter and added comments
commit 9c88100ee920b3caaccffc0da6771880fc7f15d9
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-07T05:02:18Z
Updated based on comments:
1. Documentation: added pig.md with interpreter documentation and added pig entry to index.md
2. Added test junit test based on passwd file parsing example here https://pig.apache.org/docs/r0.10.0/start.html#run
3. Removed author tag from comment (this was copied from shell interpreter https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L42)
4. Implemented cancel functionality
5. Display output stream in case of error
commit 1b36809359beb045727b4d7abaac9d1785401d5b
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-27T09:25:56Z
Merge branch 'pr/338' into ZEPPELIN-335
commit 529b3e5a29536f877229eb9bcb30a1ca53525bc3
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-28T11:41:24Z
refactor pig Interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: ZEPPELIN-335. Pig Interpreter
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
how about LICENSE file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Try the commandline from Travis?
https://github.com/apache/zeppelin/blob/master/.travis.yml#L75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
I think @AhyoungRyu has a comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@felixcheung Test is passed, I suspect the selenium test is flaky so failed last time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@felixcheung Thanks for the review, license is added and comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1476
[WIP] ZEPPELIN-335. Pig Interpreter
### What is this PR for?
Based on #338 , I refactor most of pig interpreter. As I don't think the approach in #338 is the best approach. In #338, we use script `bin/pig` to launch pig script, it is different to control that job (hard to kill and get progress and stats info). In this PR, I use pig api to launch pig script. Besides that I implement another interpreter type `%pig.query` to leverage the display system of zeppelin. For the details you can check `pig.md`
### What type of PR is it?
[Feature]
### Todos
* Syntax Highlight
* new interpreter type `%pig.udf`, so that user can write pig udf in zeppelin directly and don't need to build udf jar manually.
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-335
### How should this be tested?
Unit test is added and also manual test is done
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1476
----
commit ef2223abab92a452b48372ac0b4c50b70646f984
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T05:40:06Z
initial commit of pig interpreter
commit 656329d00a766570b25970506aa9e7a95edd8f8a
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T06:25:47Z
exposed timeout and pig executable via interpreter and added comments
commit 9c88100ee920b3caaccffc0da6771880fc7f15d9
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-07T05:02:18Z
Updated based on comments:
1. Documentation: added pig.md with interpreter documentation and added pig entry to index.md
2. Added test junit test based on passwd file parsing example here https://pig.apache.org/docs/r0.10.0/start.html#run
3. Removed author tag from comment (this was copied from shell interpreter https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L42)
4. Implemented cancel functionality
5. Display output stream in case of error
commit 1b36809359beb045727b4d7abaac9d1785401d5b
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-27T09:25:56Z
Merge branch 'pr/338' into ZEPPELIN-335
commit b98eff1697b40e467d444655b9a201e4d3dbee56
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-28T11:41:24Z
refactor pig Interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Yes, it supports local, mapreduce and tez engine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Could you add documentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by abajwa-hw <gi...@git.apache.org>.
Github user abajwa-hw commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@zjffdu thanks for working on this interpreter! Looks great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Thanks @felixcheung , Do you know how to run SELENIUM test ? I follow the instruction on READM.MD, but fails
```
Zeppelin comes with a set of end-to-end acceptance tests driving headless selenium browser
```sh
# assumes zeppelin-server running on localhost:8080 (use -Durl=.. to override)
mvn verify
# or take care of starting/stoping zeppelin-server from packaged zeppelin-distribuion/target
mvn verify -P using-packaged-distr
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1476
ZEPPELIN-335. Pig Interpreter
### What is this PR for?
Based on #338 , I refactor most of pig interpreter. As I don't think the approach in #338 is the best approach. In #338, we use script `bin/pig` to launch pig script, it is different to control that job (hard to kill and get progress and stats info). In this PR, I use pig api to launch pig script. Besides that I implement another interpreter type `%pig.query` to leverage the display system of zeppelin. For the details you can check `pig.md`
### What type of PR is it?
[Feature]
### Todos
* Syntax Highlight
* new interpreter type `%pig.udf`, so that user can write pig udf in zeppelin directly and don't need to build udf jar manually.
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-335
### How should this be tested?
Unit test is added and also manual test is done
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1476
----
commit 7abad201a63df51d04326231cbf429122540e311
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T05:40:06Z
initial commit of pig interpreter
commit 2586336e44982ac3c92156c24a288c540792d0c5
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T06:25:47Z
exposed timeout and pig executable via interpreter and added comments
commit c28beb588922a5edbc9d5db3336bbdba9a22c3a1
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-07T05:02:18Z
Updated based on comments:
1. Documentation: added pig.md with interpreter documentation and added pig entry to index.md
2. Added test junit test based on passwd file parsing example here https://pig.apache.org/docs/r0.10.0/start.html#run
3. Removed author tag from comment (this was copied from shell interpreter https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L42)
4. Implemented cancel functionality
5. Display output stream in case of error
commit a09a7f78c6f72cf8bf5623a55c71cc06141671aa
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-28T11:41:24Z
refactor pig Interpreter
commit 05a3b9b0a76423660497dfb92cf773cec1687871
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-08T03:45:22Z
add pig.md
commit 39f161a36aad72c590a2feef4c8f7b4afefe72ec
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-08T08:09:33Z
address comments
commit 5e2e222555dabfb66a7981e5d7d0d0f659ca1144
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:35:07Z
Minor update for pig.md
commit df7a6db47ca2db5b8d3ed625000d6a25f035a8e5
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:35:25Z
Add pig.md to dropdown menu
commit fe014a72b445f6977d00356bfe780c40dade0167
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:39:41Z
Fix docs title in front matter
commit 1ae7db21a32f12ce139277a8dca4e61cd391bced
Author: Jeff Zhang <zj...@gmail.com>
Date: 2016-10-09T13:23:07Z
Merge pull request #2 from AhyoungRyu/ZEPPELIN-335/docs
[ZEPPELIN-335][DOCS] Minor update for pig.md
commit 58b4b2f26dd8f852d453854a37764a824903d9cd
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-09T13:28:41Z
minor update of docs
commit c85a09031a49add7f48114afe3ea43e4b572b0f2
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-09T23:45:03Z
add license
commit e858301bdfcac727fea8ef306f42ecd252ddfe94
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-10T00:27:08Z
address comments
commit a1b742bceeff34aad1196ce2de9235810b4ce961
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-10T07:42:30Z
minor update on doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Do you intent to include the TODO in this PR, or as a follow up?
Otherwise I think this is good to go - you can remove the WIP in the title and I'll merge if there is no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Is it possible have a non-Tez version of Pig and would it work with this interpreter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
I did it, but fails with the following error:
```
*** RUN ABORTED ***
java.lang.RuntimeException: Unable to load a Suite class that was discovered in the runpath: org.apache.zeppelin.AbstractFunctionalSuite
at org.scalatest.tools.DiscoverySuite$.getSuiteInstance(DiscoverySuite.scala:84)
at org.scalatest.tools.DiscoverySuite$$anonfun$1.apply(DiscoverySuite.scala:38)
at org.scalatest.tools.DiscoverySuite$$anonfun$1.apply(DiscoverySuite.scala:37)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.Iterator$class.foreach(Iterator.scala:727)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
...
Cause: java.lang.RuntimeException: Could not initialize any driver
at org.apache.zeppelin.AbstractFunctionalSuite.getDriver(AbstractFunctionalSuite.scala:64)
at org.apache.zeppelin.AbstractFunctionalSuite.<init>(AbstractFunctionalSuite.scala:39)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
at java.lang.Class.newInstance(Class.java:442)
at org.scalatest.tools.DiscoverySuite$.getSuiteInstance(DiscoverySuite.scala:69)
at org.scalatest.tools.DiscoverySuite$$anonfun$1.apply(DiscoverySuite.scala:38)
at org.scalatest.tools.DiscoverySuite$$anonfun$1.apply(DiscoverySuite.scala:37)
```
@Leemoonsoo @bzz Do you know how to run SELENIUM test locally ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@felixcheung please check `pig.md`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Thanks @AhyoungRyu for the help, merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@zjffdu Thanks for your great work! \U0001f44d
While I was quickly looking through `pig.md`, found some need-to be-changed(?) parts. So I've just pushed my commits to your Zeppelin repo instead of leaving multiple review comments one by one in here. Could you check [https://github.com/zjffdu/zeppelin/pull/2](https://github.com/zjffdu/zeppelin/pull/2) out? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1476
Thanks, comment replied, in particular, [this](https://github.com/apache/zeppelin/pull/1476#discussion_r82544875)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
ping @Leemoonsoo @bzz @felixcheung @abajwa-hw @vgmartinez @maparco @smartinsightsfromdata please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1476
@felixcheung @AhyoungRyu 's comment is addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1476: ZEPPELIN-335. Pig Interpreter
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1476
ZEPPELIN-335. Pig Interpreter
### What is this PR for?
Based on #338 , I refactor most of pig interpreter. As I don't think the approach in #338 is the best approach. In #338, we use script `bin/pig` to launch pig script, it is different to control that job (hard to kill and get progress and stats info). In this PR, I use pig api to launch pig script. Besides that I implement another interpreter type `%pig.query` to leverage the display system of zeppelin. For the details you can check `pig.md`
### What type of PR is it?
[Feature]
### Todos
* Syntax Highlight
* new interpreter type `%pig.udf`, so that user can write pig udf in zeppelin directly and don't need to build udf jar manually.
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-335
### How should this be tested?
Unit test is added and also manual test is done
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1476
----
commit 7abad201a63df51d04326231cbf429122540e311
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T05:40:06Z
initial commit of pig interpreter
commit 2586336e44982ac3c92156c24a288c540792d0c5
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-06T06:25:47Z
exposed timeout and pig executable via interpreter and added comments
commit c28beb588922a5edbc9d5db3336bbdba9a22c3a1
Author: Ali Bajwa <ab...@hortonworks.com>
Date: 2015-10-07T05:02:18Z
Updated based on comments:
1. Documentation: added pig.md with interpreter documentation and added pig entry to index.md
2. Added test junit test based on passwd file parsing example here https://pig.apache.org/docs/r0.10.0/start.html#run
3. Removed author tag from comment (this was copied from shell interpreter https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L42)
4. Implemented cancel functionality
5. Display output stream in case of error
commit a09a7f78c6f72cf8bf5623a55c71cc06141671aa
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-28T11:41:24Z
refactor pig Interpreter
commit 05a3b9b0a76423660497dfb92cf773cec1687871
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-08T03:45:22Z
add pig.md
commit 39f161a36aad72c590a2feef4c8f7b4afefe72ec
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-08T08:09:33Z
address comments
commit 5e2e222555dabfb66a7981e5d7d0d0f659ca1144
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:35:07Z
Minor update for pig.md
commit df7a6db47ca2db5b8d3ed625000d6a25f035a8e5
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:35:25Z
Add pig.md to dropdown menu
commit fe014a72b445f6977d00356bfe780c40dade0167
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-10-09T12:39:41Z
Fix docs title in front matter
commit 1ae7db21a32f12ce139277a8dca4e61cd391bced
Author: Jeff Zhang <zj...@gmail.com>
Date: 2016-10-09T13:23:07Z
Merge pull request #2 from AhyoungRyu/ZEPPELIN-335/docs
[ZEPPELIN-335][DOCS] Minor update for pig.md
commit 58b4b2f26dd8f852d453854a37764a824903d9cd
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-09T13:28:41Z
minor update of docs
commit c85a09031a49add7f48114afe3ea43e4b572b0f2
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-09T23:45:03Z
add license
commit e858301bdfcac727fea8ef306f42ecd252ddfe94
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-10T00:27:08Z
address comments
commit a1b742bceeff34aad1196ce2de9235810b4ce961
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-10T07:42:30Z
minor update on doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---