You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andreas Köhler (Created JIRA)" <ji...@apache.org> on 2011/11/20 21:13:51 UTC
[jira] [Created] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
HeaderResponseContainerFilteringHeaderResponse does not override enough methods
-------------------------------------------------------------------------------
Key: WICKET-4247
URL: https://issues.apache.org/jira/browse/WICKET-4247
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.3
Reporter: Andreas Köhler
Seen on Wicket 1.5.3 and I think it is still there in SVN.
Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4247.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 6.0.0)
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172107#comment-13172107 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
Sure, just give me a few days to find some spare time :-)
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Köhler updated WICKET-4247:
-----------------------------------
Attachment: wicket-4247.tar.bz2
Quickstart
Watch WicketApplication.PROXY_HEADER_RESPONSE
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Emond Papegaaij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181332#comment-13181332 ]
Emond Papegaaij commented on WICKET-4247:
-----------------------------------------
You are right. I've committed your patch: http://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=56ab23584fcb1c3949e69255078239c85dacea69
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-Fix-latest-two-js-additions-to-HeaderRes.patch, 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170249#comment-13170249 ]
Martin Grigorov commented on WICKET-4247:
-----------------------------------------
@Andreas: do you need this fix in 1.5 ?
These classes are reworked in 6.0 and I'd like to save myself some time if this ticket is only for consistency and completeness and it is not really a stopper for you.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-4247:
-------------------------------------
It is fragile :-)
But this is just because not that many people use these classes...
I'd like to rework IHeaderResponse to have just: renderText(), renderCss(CssAttributes) and renderJavaScript(JavaScriptAttributes). These XyzAttributes will have all specifics for <link/> and <script/>.
Not sure whether this will be part of Wicket 6.0 but it should be soon because more people like you will start using this fragile classes :-)
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181291#comment-13181291 ]
Martin Grigorov commented on WICKET-4247:
-----------------------------------------
I did: http://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commitdiff;h=4e760f5a
I switched to Git recently.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Emond Papegaaij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170420#comment-13170420 ]
Emond Papegaaij commented on WICKET-4247:
-----------------------------------------
Perhaps for 1.5, it's as easy as adding the last few methods? New methods will not get added in 1.5, as that's an API break.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181313#comment-13181313 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
Oh, I missed that. Great decision, btw :-D
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172100#comment-13172100 ]
Martin Grigorov commented on WICKET-4247:
-----------------------------------------
Applying a patch is easy :-)
Attach it and I'll commit it.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172097#comment-13172097 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
It is no stopper for me, but only because I work around and do not use the missing functions.
+1 for Emond's comment.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181323#comment-13181323 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
I think the patch had a typo, at least my app stopped working...
Please consider the new patch which sits on top of the other.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-Fix-latest-two-js-additions-to-HeaderRes.patch, 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Köhler updated WICKET-4247:
-----------------------------------
Attachment: 0001-WICKET-4247-Fix-latest-two-js-additions-to-HeaderRes.patch
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-Fix-latest-two-js-additions-to-HeaderRes.patch, 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Emond Papegaaij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169346#comment-13169346 ]
Emond Papegaaij commented on WICKET-4247:
-----------------------------------------
In the branch on github at https://github.com/papegaaij/wicket/commits/wicket+wiquery IHeaderResponse has been rewritten, including the filters, which fixes this issue.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4247:
---------------------------------------
Assignee: Martin Grigorov
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158757#comment-13158757 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
I think I was wrong about "It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this. ".
There are still two methods missing. This looks fragile to me :)
So, what shall I do about?
#renderJavaScriptReference(String, String, boolean)
#renderJavaScriptReference(String, String, boolean, String)
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Emond Papegaaij (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4247:
------------------------------------
Attachment: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch
Fixes the issue in 1.5 by overriding the last 2 methods.
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4247.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.4
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4, 6.0.0
>
> Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4247)
HeaderResponseContainerFilteringHeaderResponse does not override enough
methods
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181285#comment-13181285 ]
Andreas Köhler commented on WICKET-4247:
----------------------------------------
Martin, did you really apply the latest patch? I cannot find it.
Kudos to Emond!
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
> Key: WICKET-4247
> URL: https://issues.apache.org/jira/browse/WICKET-4247
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Martin Grigorov
> Fix For: 1.5.4
>
> Attachments: 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira